Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: pdf/chunk_stream_unittest.cc

Issue 2455403002: Reland of Improve linearized pdf load/show time. (Closed)
Patch Set: Fix review issues Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pdf/chunk_stream.cc ('k') | pdf/document_loader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdf/chunk_stream_unittest.cc
diff --git a/pdf/chunk_stream_unittest.cc b/pdf/chunk_stream_unittest.cc
index af7685022f1986204676200243cacd1bee3f0cdb..f6b3f3c2e91a4da4a39802f954461e46c738aeb1 100644
--- a/pdf/chunk_stream_unittest.cc
+++ b/pdf/chunk_stream_unittest.cc
@@ -4,14 +4,96 @@
#include "pdf/chunk_stream.h"
+#include <array>
+#include <memory>
+
+#include "base/memory/ptr_util.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace chrome_pdf {
+namespace {
+typedef ChunkStream<10> TestChunkStream;
+
+std::unique_ptr<TestChunkStream::ChunkData> CreateChunkData() {
+ return base::MakeUnique<TestChunkStream::ChunkData>();
+}
+}
+
+TEST(ChunkStreamTest, InRow) {
+ TestChunkStream stream;
+ EXPECT_FALSE(stream.IsComplete());
+ EXPECT_FALSE(stream.IsRangeAvailable(gfx::Range(0, 10)));
+ stream.SetChunkData(0, CreateChunkData());
+ EXPECT_TRUE(stream.IsRangeAvailable(gfx::Range(0, 10)));
+ EXPECT_FALSE(stream.IsRangeAvailable(gfx::Range(0, 20)));
+ stream.SetChunkData(1, CreateChunkData());
+ EXPECT_TRUE(stream.IsRangeAvailable(gfx::Range(0, 20)));
+ EXPECT_FALSE(stream.IsRangeAvailable(gfx::Range(0, 30)));
+ stream.SetChunkData(2, CreateChunkData());
+ EXPECT_TRUE(stream.IsRangeAvailable(gfx::Range(0, 30)));
+ stream.set_eof_pos(25);
+ EXPECT_FALSE(stream.IsRangeAvailable(gfx::Range(0, 30)));
+ EXPECT_TRUE(stream.IsRangeAvailable(gfx::Range(0, 25)));
+ EXPECT_TRUE(stream.IsComplete());
+}
-TEST(ChunkStreamTest, Simple) {
- ChunkStream stream;
- stream.Preallocate(1000);
- EXPECT_FALSE(stream.IsRangeAvailable(100, 500));
+TEST(ChunkStreamTest, InBackRow) {
+ TestChunkStream stream;
+ stream.set_eof_pos(25);
+ EXPECT_FALSE(stream.IsComplete());
+ EXPECT_FALSE(stream.IsRangeAvailable(gfx::Range(20, 25)));
+ stream.SetChunkData(2, CreateChunkData());
+ EXPECT_TRUE(stream.IsRangeAvailable(gfx::Range(20, 25)));
+ EXPECT_FALSE(stream.IsRangeAvailable(gfx::Range(10, 20)));
+ stream.SetChunkData(1, CreateChunkData());
+ EXPECT_TRUE(stream.IsRangeAvailable(gfx::Range(10, 20)));
+ EXPECT_FALSE(stream.IsRangeAvailable(gfx::Range(0, 10)));
+ stream.SetChunkData(0, CreateChunkData());
+ EXPECT_TRUE(stream.IsRangeAvailable(gfx::Range(0, 10)));
+ EXPECT_TRUE(stream.IsComplete());
}
+TEST(ChunkStreamTest, FillGap) {
+ TestChunkStream stream;
+ stream.set_eof_pos(25);
+ EXPECT_FALSE(stream.IsComplete());
+ stream.SetChunkData(0, CreateChunkData());
+ stream.SetChunkData(2, CreateChunkData());
+ EXPECT_TRUE(stream.IsRangeAvailable(gfx::Range(0, 10)));
+ EXPECT_TRUE(stream.IsRangeAvailable(gfx::Range(20, 25)));
+ EXPECT_FALSE(stream.IsRangeAvailable(gfx::Range(0, 25)));
+ stream.SetChunkData(1, CreateChunkData());
+ EXPECT_TRUE(stream.IsRangeAvailable(gfx::Range(0, 25)));
+ EXPECT_TRUE(stream.IsComplete());
+}
+
+TEST(ChunkStreamTest, Read) {
+ TestChunkStream stream;
+ stream.set_eof_pos(25);
+ const unsigned char start_value = 33;
+ unsigned char value = start_value;
+ auto chunk_0 = CreateChunkData();
+ for (auto& it : *chunk_0) {
+ it = ++value;
+ }
+ auto chunk_1 = CreateChunkData();
+ for (auto& it : *chunk_1) {
+ it = ++value;
+ }
+ auto chunk_2 = CreateChunkData();
+ for (auto& it : *chunk_2) {
+ it = ++value;
+ }
+ stream.SetChunkData(0, std::move(chunk_0));
+ stream.SetChunkData(2, std::move(chunk_2));
+ stream.SetChunkData(1, std::move(chunk_1));
+
+ std::array<unsigned char, 25> result_data;
+ EXPECT_TRUE(stream.ReadData(gfx::Range(0, 25), result_data.data()));
+
+ value = start_value;
+ for (const auto& it : result_data) {
+ EXPECT_EQ(++value, it);
+ }
+}
} // namespace chrome_pdf
« no previous file with comments | « pdf/chunk_stream.cc ('k') | pdf/document_loader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698