Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1070)

Issue 2455183002: Simplify layout of tray items and fix spacing for MD. (Closed)

Created:
4 years, 1 month ago by Evan Stade
Modified:
4 years, 1 month ago
Reviewers:
tdanderson
CC:
chromium-reviews, kalyank, stevenjb+watch_chromium.org, oshima+watch_chromium.org, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify layout of tray items and fix spacing for MD. BUG=653292 Committed: https://crrev.com/2449770edb6a482bf442bcdb669cd15d5a2f2632 Cr-Commit-Position: refs/heads/master@{#428454}

Patch Set 1 #

Total comments: 16

Patch Set 2 : more fixes #

Total comments: 4

Patch Set 3 : tda review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -75 lines) Patch
M ash/common/system/chromeos/network/tray_network.cc View 4 chunks +3 lines, -19 lines 0 comments Download
M ash/common/system/chromeos/power/tray_power.cc View 1 4 chunks +8 lines, -4 lines 0 comments Download
M ash/common/system/date/date_view.cc View 1 2 3 chunks +9 lines, -11 lines 0 comments Download
M ash/common/system/date/tray_date.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ash/common/system/tray/fixed_sized_image_view.cc View 1 chunk +1 line, -4 lines 0 comments Download
M ash/common/system/tray/system_tray.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ash/common/system/tray/tray_image_item.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/common/system/tray/tray_image_item.cc View 1 3 chunks +0 lines, -11 lines 0 comments Download
M ash/common/system/tray/tray_item_view.h View 1 chunk +0 lines, -6 lines 0 comments Download
M ash/common/system/tray/tray_item_view.cc View 1 4 chunks +21 lines, -12 lines 0 comments Download
M ash/common/system/tray/tray_utils.cc View 1 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
Evan Stade
net negative lines of code 8) https://codereview.chromium.org/2455183002/diff/1/ash/common/system/chromeos/network/tray_network.cc File ash/common/system/chromeos/network/tray_network.cc (left): https://codereview.chromium.org/2455183002/diff/1/ash/common/system/chromeos/network/tray_network.cc#oldcode52 ash/common/system/chromeos/network/tray_network.cc:52: new views::BoxLayout(views::BoxLayout::kHorizontal, 0, ...
4 years, 1 month ago (2016-10-27 19:05:30 UTC) #2
tdanderson
Evan, please see my comments below: https://codereview.chromium.org/2455183002/diff/1/ash/common/system/chromeos/network/tray_network.cc File ash/common/system/chromeos/network/tray_network.cc (left): https://codereview.chromium.org/2455183002/diff/1/ash/common/system/chromeos/network/tray_network.cc#oldcode52 ash/common/system/chromeos/network/tray_network.cc:52: new views::BoxLayout(views::BoxLayout::kHorizontal, 0, ...
4 years, 1 month ago (2016-10-27 19:28:01 UTC) #3
Evan Stade
latest patch also improves TrayIME and TrayDate https://codereview.chromium.org/2455183002/diff/1/ash/common/system/tray/tray_item_view.cc File ash/common/system/tray/tray_item_view.cc (right): https://codereview.chromium.org/2455183002/diff/1/ash/common/system/tray/tray_item_view.cc#newcode55 ash/common/system/tray/tray_item_view.cc:55: views::Background::CreateSolidBackground(SK_ColorGREEN)); On ...
4 years, 1 month ago (2016-10-27 21:36:34 UTC) #6
tdanderson
Looks like the trybot failures are relevant, but lgtm with those addressed. https://codereview.chromium.org/2455183002/diff/20001/ash/common/system/date/date_view.cc File ash/common/system/date/date_view.cc ...
4 years, 1 month ago (2016-10-27 23:58:41 UTC) #9
Evan Stade
On 2016/10/27 23:58:41, tdanderson wrote: > Looks like the trybot failures are relevant, but lgtm ...
4 years, 1 month ago (2016-10-28 18:07:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455183002/40001
4 years, 1 month ago (2016-10-28 18:12:20 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-28 19:10:28 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 19:24:39 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2449770edb6a482bf442bcdb669cd15d5a2f2632
Cr-Commit-Position: refs/heads/master@{#428454}

Powered by Google App Engine
This is Rietveld 408576698