Simplify layout of tray items and fix spacing for MD.

ash/common/system/tray/tray_image_item.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/system/tray/tray_image_item.h"
 
 #include "ash/common/material_design/material_design_controller.h"
 #include "ash/common/shelf/wm_shelf_util.h"
 #include "ash/common/system/tray/system_tray.h"
 #include "ash/common/system/tray/tray_constants.h"
@@ skipping 71 matching lines @@
 }
 
 views::View* TrayImageItem::CreateDetailedView(LoginStatus status) {
   return nullptr;
 }
 
 void TrayImageItem::UpdateAfterLoginStatusChange(LoginStatus status) {}
 
 void TrayImageItem::UpdateAfterShelfAlignmentChange(ShelfAlignment alignment) {
   SetTrayImageItemBorder(tray_view_, alignment);
-  SetItemAlignment(alignment);
 }
 
 void TrayImageItem::DestroyTrayView() {
   tray_view_ = nullptr;
 }
 
 void TrayImageItem::DestroyDefaultView() {}
 
 void TrayImageItem::DestroyDetailedView() {}
 
 void TrayImageItem::SetIconColor(SkColor color) {
   icon_color_ = color;
   UpdateImageOnImageView();
 }
 
 void TrayImageItem::SetImageFromResourceId(int resource_id) {
   resource_id_ = resource_id;
   UpdateImageOnImageView();
 }
 
-void TrayImageItem::SetItemAlignment(ShelfAlignment alignment) {
-  // Center the item dependent on the orientation of the shelf.
-  views::BoxLayout::Orientation layout = IsHorizontalAlignment(alignment)
-                                             ? views::BoxLayout::kHorizontal

[Evan Stade, 2016/10/27 19:05:30]

use the TrayItemView's fill layout. ImageView already centers the actual Image.

[tdanderson, 2016/10/27 19:28:00]

Acknowledged.

-                                             : views::BoxLayout::kVertical;
-  tray_view_->SetLayoutManager(new views::BoxLayout(layout, 0, 0, 0));
-  tray_view_->Layout();
-}
-
 void TrayImageItem::UpdateImageOnImageView() {
   if (!tray_view_)
     return;
 
   if (MaterialDesignController::UseMaterialDesignSystemIcons()) {
     tray_view_->image_view()->SetImage(gfx::CreateVectorIcon(
         ResourceIdToVectorIcon(resource_id_), kTrayIconSize, icon_color_));
   } else {
     tray_view_->image_view()->SetImage(ui::ResourceBundle::GetSharedInstance()
                                            .GetImageNamed(resource_id_)
                                            .ToImageSkia());
   }
 }
 
 }  // namespace ash