Simplify layout of tray items and fix spacing for MD.

ash/common/system/tray/tray_item_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/system/tray/tray_item_view.h"
 
+#include "ash/common/material_design/material_design_controller.h"
 #include "ash/common/shelf/wm_shelf_util.h"
 #include "ash/common/system/tray/system_tray.h"
 #include "ash/common/system/tray/system_tray_item.h"
+#include "ash/common/system/tray/tray_constants.h"
 #include "ash/public/cpp/shelf_types.h"
 #include "ui/compositor/layer.h"
 #include "ui/gfx/animation/slide_animation.h"
 #include "ui/views/controls/image_view.h"
 #include "ui/views/controls/label.h"
-#include "ui/views/layout/box_layout.h"
+#include "ui/views/layout/fill_layout.h"
 #include "ui/views/widget/widget.h"
 
 namespace {
 const int kTrayIconHeight = 29;
 const int kTrayIconWidth = 29;
 const int kTrayItemAnimationDurationMS = 200;
 
 // Animations can be disabled for testing.
 bool animations_enabled = true;
 }
 
 namespace ash {
 
 TrayItemView::TrayItemView(SystemTrayItem* owner)
     : owner_(owner), label_(NULL), image_view_(NULL) {
   SetPaintToLayer(true);
   layer()->SetFillsBoundsOpaquely(false);
-  SetLayoutManager(
-      new views::BoxLayout(views::BoxLayout::kHorizontal, 0, 0, 0));
+  SetLayoutManager(new views::FillLayout());
 }
 
 TrayItemView::~TrayItemView() {}
 
 // static
 void TrayItemView::DisableAnimationsForTest() {
   animations_enabled = false;
 }
 
 void TrayItemView::CreateLabel() {
   label_ = new views::Label;
   AddChildView(label_);
+  PreferredSizeChanged();
 }
 
 void TrayItemView::CreateImageView() {
   image_view_ = new views::ImageView;
   AddChildView(image_view_);
+  image_view_->set_background(
+      views::Background::CreateSolidBackground(SK_ColorGREEN));

[tdanderson, 2016/10/27 19:28:01]

Is this for debugging?

[Evan Stade, 2016/10/27 21:36:34]

oops.

+  PreferredSizeChanged();
 }
 
 void TrayItemView::SetVisible(bool set_visible) {
   if (!GetWidget() || !animations_enabled) {
     views::View::SetVisible(set_visible);
     return;
   }
 
   if (!animation_) {
     animation_.reset(new gfx::SlideAnimation(this));
     animation_->SetSlideDuration(GetAnimationDurationMS());
     animation_->SetTweenType(gfx::Tween::LINEAR);
     animation_->Reset(visible() ? 1.0 : 0.0);
   }
 
   if (!set_visible) {
     animation_->Hide();
     AnimationProgressed(animation_.get());
   } else {
     animation_->Show();
     AnimationProgressed(animation_.get());
     views::View::SetVisible(true);
   }
 }
 
-gfx::Size TrayItemView::DesiredSize() const {
-  return views::View::GetPreferredSize();
-}
-
 int TrayItemView::GetAnimationDurationMS() {
   return kTrayItemAnimationDurationMS;
 }
 
 gfx::Size TrayItemView::GetPreferredSize() const {
-  gfx::Size size = DesiredSize();
-  if (IsHorizontalAlignment(owner()->system_tray()->shelf_alignment()))
-    size.set_height(kTrayIconHeight);
-  else
-    size.set_width(kTrayIconWidth);
+  gfx::Size size;
+  if (MaterialDesignController::UseMaterialDesignSystemIcons()) {
+    gfx::Size inner_size = views::View::GetPreferredSize();
+    if (image_view_ && child_count() == 1)
+      inner_size = gfx::Size(kTrayIconSize, kTrayIconSize);

[tdanderson, 2016/10/27 19:28:01]

I don't really see the purpose of |inner_size|. Why do you mutate |inner_size|
here but then never use it before it goes out of scope?

[Evan Stade, 2016/10/27 21:36:34]

another oops. I'm not sure how it worked like this. I must have got it working,
refactored and forgotten to test my refactor. Anyway, fixed now.

+    const int kInterTrayItemPadding = 6;
+    size.Enlarge(kInterTrayItemPadding, kInterTrayItemPadding);
+  } else {
+    size = views::View::GetPreferredSize();
+    if (IsHorizontalAlignment(owner()->system_tray()->shelf_alignment()))
+      size.set_height(kTrayIconHeight);
+    else
+      size.set_width(kTrayIconWidth);
+  }
   if (!animation_.get() || !animation_->is_animating())
     return size;
   if (IsHorizontalAlignment(owner()->system_tray()->shelf_alignment())) {
     size.set_width(std::max(
         1, static_cast<int>(size.width() * animation_->GetCurrentValue())));
   } else {
     size.set_height(std::max(
         1, static_cast<int>(size.height() * animation_->GetCurrentValue())));
   }
   return size;
@@ skipping 25 matching lines @@
 void TrayItemView::AnimationEnded(const gfx::Animation* animation) {
   if (animation->GetCurrentValue() < 0.1)
     views::View::SetVisible(false);
 }
 
 void TrayItemView::AnimationCanceled(const gfx::Animation* animation) {
   AnimationEnded(animation);
 }
 
 }  // namespace ash