Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 2454903002: Removed unused StyleEngine::didRemoveShadowRoot(). (Closed)

Created:
4 years, 1 month ago by rune
Modified:
4 years, 1 month ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews-style_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed unused StyleEngine::didRemoveShadowRoot(). Also tried to figure out and document why we are clearing ScopedStyleResolvers for shadow trees in clearResolver(). R=meade@chromium.org Committed: https://crrev.com/add89dccfa58602f8875c289a935e5cccd3f353c Cr-Commit-Position: refs/heads/master@{#427950}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
M third_party/WebKit/Source/core/dom/StyleEngine.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 2 chunks +12 lines, -13 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
rune
ptal
4 years, 1 month ago (2016-10-26 23:59:09 UTC) #2
meade_UTC10
lgtm
4 years, 1 month ago (2016-10-27 01:42:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454903002/1
4 years, 1 month ago (2016-10-27 05:54:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 05:58:45 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 06:00:17 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/add89dccfa58602f8875c289a935e5cccd3f353c
Cr-Commit-Position: refs/heads/master@{#427950}

Powered by Google App Engine
This is Rietveld 408576698