Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2450353002: Clear m_treeBoundaryCrossingScopes when reconstructing StyleResolver. (Closed)

Created:
4 years, 1 month ago by rune
Modified:
4 years, 1 month ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews-style_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear m_treeBoundaryCrossingScopes when reconstructing StyleResolver. When m_treeBoundaryCrossingScopes were part of StyleResolver, they were cleared when the StyleResolver was cleared. Now that they outlive the StyleResolver, they need to be cleared separately. R=meade@chromium.org BUG=659653 Committed: https://crrev.com/aed5a7036ec6809d303ca5db7bc3e91c17ac72b6 Cr-Commit-Position: refs/heads/master@{#427912}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/css/boundary-crossing-scopes-null-resolver-crash.html View 1 chunk +29 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
rune
ptal
4 years, 1 month ago (2016-10-26 22:33:39 UTC) #2
meade_UTC10
lgtm
4 years, 1 month ago (2016-10-27 01:40:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450353002/1
4 years, 1 month ago (2016-10-27 01:57:33 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 02:03:40 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 02:06:51 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aed5a7036ec6809d303ca5db7bc3e91c17ac72b6
Cr-Commit-Position: refs/heads/master@{#427912}

Powered by Google App Engine
This is Rietveld 408576698