Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2456753003: Use StyleEngine::resetAuthorStyle instead of clearScopedStyleResolver. (Closed)

Created:
4 years, 1 month ago by rune
Modified:
4 years, 1 month ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use StyleEngine::resetAuthorStyle instead of clearScopedStyleResolver. The former will make sure the shadow root is removed from treeBoundaryCrossingScopes appropriately. This code is not in production yet, so there were no observable bug. R=meade@chromium.org Committed: https://crrev.com/7ddd9705acfb4c7fd15a381be6f9c8f5aa58be1a Cr-Commit-Position: refs/heads/master@{#428275}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -3 lines) Patch
M third_party/WebKit/Source/core/css/ActiveStyleSheets.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/ActiveStyleSheetsTest.cpp View 2 chunks +29 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/StyleSheetList.h View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
rune
ptal
4 years, 1 month ago (2016-10-27 11:04:18 UTC) #3
meade_UTC10
lgtm
4 years, 1 month ago (2016-10-28 01:50:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456753003/20001
4 years, 1 month ago (2016-10-28 03:44:21 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-28 03:49:21 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 03:52:14 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7ddd9705acfb4c7fd15a381be6f9c8f5aa58be1a
Cr-Commit-Position: refs/heads/master@{#428275}

Powered by Google App Engine
This is Rietveld 408576698