Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2453683011: Remove FX_BOOL from fpdfsdk. (Closed)

Created:
4 years, 1 month ago by Tom Sepez
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Regenerate patch after rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5265 lines, -5460 lines) Patch
M fpdfsdk/cfx_systemhandler.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/cpdfsdk_annot.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/cpdfsdk_annot.cpp View 1 2 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/cpdfsdk_annothandlermgr.h View 1 chunk +38 lines, -38 lines 0 comments Download
M fpdfsdk/cpdfsdk_annothandlermgr.cpp View 12 chunks +30 lines, -30 lines 0 comments Download
M fpdfsdk/cpdfsdk_baannot.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/cpdfsdk_baannot.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M fpdfsdk/cpdfsdk_baannothandler.h View 3 chunks +41 lines, -45 lines 0 comments Download
M fpdfsdk/cpdfsdk_baannothandler.cpp View 1 3 chunks +66 lines, -70 lines 0 comments Download
M fpdfsdk/cpdfsdk_formfillenvironment.h View 1 6 chunks +21 lines, -21 lines 0 comments Download
M fpdfsdk/cpdfsdk_formfillenvironment.cpp View 1 9 chunks +31 lines, -31 lines 0 comments Download
M fpdfsdk/cpdfsdk_interform.h View 4 chunks +36 lines, -37 lines 0 comments Download
M fpdfsdk/cpdfsdk_interform.cpp View 1 24 chunks +85 lines, -86 lines 0 comments Download
M fpdfsdk/cpdfsdk_pageview.h View 4 chunks +22 lines, -22 lines 0 comments Download
M fpdfsdk/cpdfsdk_pageview.cpp View 1 11 chunks +56 lines, -57 lines 0 comments Download
M fpdfsdk/cpdfsdk_widget.h View 6 chunks +25 lines, -25 lines 0 comments Download
M fpdfsdk/cpdfsdk_widget.cpp View 1 30 chunks +92 lines, -93 lines 0 comments Download
M fpdfsdk/cpdfsdk_widgethandler.h View 3 chunks +41 lines, -45 lines 0 comments Download
M fpdfsdk/cpdfsdk_widgethandler.cpp View 1 6 chunks +74 lines, -76 lines 0 comments Download
M fpdfsdk/cpdfsdk_xfawidget.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_xfawidget.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/cpdfsdk_xfawidgethandler.h View 2 chunks +41 lines, -45 lines 0 comments Download
M fpdfsdk/cpdfsdk_xfawidgethandler.cpp View 1 6 chunks +71 lines, -78 lines 0 comments Download
M fpdfsdk/formfiller/cffl_checkbox.h View 1 chunk +8 lines, -10 lines 0 comments Download
M fpdfsdk/formfiller/cffl_checkbox.cpp View 1 chunk +23 lines, -23 lines 0 comments Download
M fpdfsdk/formfiller/cffl_combobox.h View 2 chunks +7 lines, -9 lines 0 comments Download
M fpdfsdk/formfiller/cffl_combobox.cpp View 14 chunks +27 lines, -27 lines 0 comments Download
M fpdfsdk/formfiller/cffl_formfiller.h View 6 chunks +55 lines, -57 lines 0 comments Download
M fpdfsdk/formfiller/cffl_formfiller.cpp View 14 chunks +121 lines, -122 lines 0 comments Download
M fpdfsdk/formfiller/cffl_interactiveformfiller.h View 3 chunks +64 lines, -69 lines 0 comments Download
M fpdfsdk/formfiller/cffl_interactiveformfiller.cpp View 33 chunks +174 lines, -179 lines 0 comments Download
M fpdfsdk/formfiller/cffl_listbox.h View 2 chunks +3 lines, -5 lines 0 comments Download
M fpdfsdk/formfiller/cffl_listbox.cpp View 7 chunks +20 lines, -20 lines 0 comments Download
M fpdfsdk/formfiller/cffl_pushbutton.h View 1 chunk +1 line, -3 lines 0 comments Download
M fpdfsdk/formfiller/cffl_pushbutton.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/formfiller/cffl_radiobutton.h View 1 chunk +8 lines, -10 lines 0 comments Download
M fpdfsdk/formfiller/cffl_radiobutton.cpp View 1 chunk +25 lines, -25 lines 0 comments Download
M fpdfsdk/formfiller/cffl_textfield.h View 2 chunks +7 lines, -9 lines 0 comments Download
M fpdfsdk/formfiller/cffl_textfield.cpp View 11 chunks +30 lines, -30 lines 0 comments Download
M fpdfsdk/fpdf_dataavail.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdf_ext.cpp View 1 3 chunks +8 lines, -8 lines 0 comments Download
M fpdfsdk/fpdf_flatten.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M fpdfsdk/fpdf_progressive.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdf_sysfontinfo.cpp View 2 chunks +11 lines, -11 lines 0 comments Download
M fpdfsdk/fpdf_transformpage.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/fpdfdoc.cpp View 6 chunks +11 lines, -11 lines 0 comments Download
M fpdfsdk/fpdfeditimg.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M fpdfsdk/fpdfeditpage.cpp View 1 3 chunks +10 lines, -10 lines 0 comments Download
M fpdfsdk/fpdfformfill.cpp View 1 13 chunks +17 lines, -17 lines 0 comments Download
M fpdfsdk/fpdfppo.cpp View 16 chunks +46 lines, -46 lines 0 comments Download
M fpdfsdk/fpdfsave.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/fpdftext.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdfview.cpp View 1 10 chunks +24 lines, -24 lines 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_context.h View 1 2 chunks +11 lines, -11 lines 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_context.cpp View 1 5 chunks +20 lines, -20 lines 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.h View 1 3 chunks +32 lines, -32 lines 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp View 1 22 chunks +77 lines, -78 lines 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_page.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_page.cpp View 1 2 chunks +17 lines, -17 lines 0 comments Download
M fpdfsdk/fsdk_actionhandler.h View 3 chunks +63 lines, -63 lines 0 comments Download
M fpdfsdk/fsdk_actionhandler.cpp View 27 chunks +59 lines, -59 lines 0 comments Download
M fpdfsdk/fsdk_define.h View 1 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fsdk_pauseadapter.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fsdk_pauseadapter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fxedit/fxet_edit.h View 13 chunks +76 lines, -76 lines 0 comments Download
M fpdfsdk/fxedit/fxet_edit.cpp View 59 chunks +157 lines, -157 lines 0 comments Download
M fpdfsdk/fxedit/fxet_list.h View 7 chunks +25 lines, -25 lines 0 comments Download
M fpdfsdk/fxedit/fxet_list.cpp View 19 chunks +50 lines, -50 lines 0 comments Download
M fpdfsdk/ipdfsdk_annothandler.h View 3 chunks +45 lines, -45 lines 0 comments Download
M fpdfsdk/javascript/Annot.h View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/javascript/Annot.cpp View 2 chunks +12 lines, -18 lines 0 comments Download
M fpdfsdk/javascript/Document.h View 3 chunks +166 lines, -170 lines 0 comments Download
M fpdfsdk/javascript/Document.cpp View 39 chunks +443 lines, -445 lines 0 comments Download
M fpdfsdk/javascript/Field.h View 5 chunks +154 lines, -174 lines 0 comments Download
M fpdfsdk/javascript/Field.cpp View 147 chunks +564 lines, -586 lines 0 comments Download
M fpdfsdk/javascript/Icon.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/Icon.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/javascript/JS_Define.h View 5 chunks +11 lines, -13 lines 0 comments Download
M fpdfsdk/javascript/JS_EventHandler.h View 4 chunks +46 lines, -70 lines 0 comments Download
M fpdfsdk/javascript/JS_EventHandler.cpp View 26 chunks +66 lines, -66 lines 0 comments Download
M fpdfsdk/javascript/JS_GlobalData.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/javascript/JS_GlobalData.cpp View 3 chunks +13 lines, -14 lines 0 comments Download
M fpdfsdk/javascript/JS_Runtime_Stub.cpp View 3 chunks +50 lines, -51 lines 0 comments Download
M fpdfsdk/javascript/PublicMethods.h View 1 chunk +63 lines, -63 lines 0 comments Download
M fpdfsdk/javascript/PublicMethods.cpp View 34 chunks +183 lines, -192 lines 0 comments Download
M fpdfsdk/javascript/app.h View 1 chunk +80 lines, -88 lines 0 comments Download
M fpdfsdk/javascript/app.cpp View 1 16 chunks +172 lines, -177 lines 0 comments Download
M fpdfsdk/javascript/cjs_context.h View 3 chunks +46 lines, -47 lines 0 comments Download
M fpdfsdk/javascript/cjs_context.cpp View 7 chunks +51 lines, -51 lines 0 comments Download
M fpdfsdk/javascript/cjs_runtime.h View 1 chunk +7 lines, -7 lines 0 comments Download
M fpdfsdk/javascript/cjs_runtime.cpp View 1 3 chunks +8 lines, -8 lines 0 comments Download
M fpdfsdk/javascript/color.h View 1 chunk +20 lines, -22 lines 0 comments Download
M fpdfsdk/javascript/color.cpp View 5 chunks +19 lines, -19 lines 0 comments Download
M fpdfsdk/javascript/console.h View 1 chunk +13 lines, -13 lines 0 comments Download
M fpdfsdk/javascript/console.cpp View 1 chunk +20 lines, -20 lines 0 comments Download
M fpdfsdk/javascript/event.h View 1 chunk +20 lines, -28 lines 0 comments Download
M fpdfsdk/javascript/event.cpp View 4 chunks +87 lines, -103 lines 0 comments Download
M fpdfsdk/javascript/global.h View 1 chunk +18 lines, -18 lines 0 comments Download
M fpdfsdk/javascript/global.cpp View 9 chunks +48 lines, -48 lines 0 comments Download
M fpdfsdk/javascript/ijs_context.h View 2 chunks +46 lines, -46 lines 0 comments Download
M fpdfsdk/javascript/ijs_runtime.h View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/javascript/report.h View 1 chunk +8 lines, -8 lines 0 comments Download
M fpdfsdk/javascript/report.cpp View 1 chunk +10 lines, -10 lines 0 comments Download
M fpdfsdk/javascript/util.h View 1 chunk +20 lines, -20 lines 0 comments Download
M fpdfsdk/javascript/util.cpp View 9 chunks +38 lines, -39 lines 0 comments Download
M fpdfsdk/pdfsdk_fieldaction.h View 1 chunk +6 lines, -6 lines 0 comments Download
M fpdfsdk/pdfsdk_fieldaction.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Button.h View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Button.cpp View 2 chunks +7 lines, -8 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Caret.h View 3 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Caret.cpp View 3 chunks +9 lines, -9 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_ComboBox.h View 5 chunks +10 lines, -10 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_ComboBox.cpp View 15 chunks +61 lines, -64 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Edit.h View 6 chunks +25 lines, -25 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Edit.cpp View 20 chunks +86 lines, -86 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_EditCtrl.h View 5 chunks +14 lines, -14 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_EditCtrl.cpp View 16 chunks +53 lines, -56 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_FontMap.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_FontMap.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Icon.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_Icon.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_ListBox.h View 5 chunks +15 lines, -15 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_ListBox.cpp View 9 chunks +36 lines, -37 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_ScrollBar.h View 6 chunks +13 lines, -13 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_ScrollBar.cpp View 23 chunks +47 lines, -51 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_SpecialButton.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_SpecialButton.cpp View 3 chunks +13 lines, -14 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Utils.h View 5 chunks +11 lines, -11 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Utils.cpp View 31 chunks +59 lines, -52 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Wnd.h View 8 chunks +38 lines, -38 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Wnd.cpp View 20 chunks +48 lines, -50 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Tom Sepez
(Still requires some baking of previous FX_BOOL change)
4 years, 1 month ago (2016-10-28 22:15:50 UTC) #1
Tom Sepez
4 years, 1 month ago (2016-10-28 22:38:39 UTC) #7
Lei Zhang
lgtm !
4 years, 1 month ago (2016-10-28 22:40:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453683011/20001
4 years, 1 month ago (2016-11-02 21:11:10 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 21:37:59 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/4cf551577856f89103e162edc761def44ffb...

Powered by Google App Engine
This is Rietveld 408576698