Remove FX_BOOL from fpdfsdk.

fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp

 // Copyright 2016 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.h"
 
 #include "core/fpdfapi/parser/cpdf_array.h"
 #include "core/fpdfapi/parser/cpdf_stream_acc.h"
@@ skipping 54 matching lines @@
   CPDFSDK_FormFillEnvironment* pFormFillEnv = m_pContext->GetFormFillEnv();
   if (!pFormFillEnv)
     return;
 
   CFX_FloatRect rcPage = CFX_FloatRect::FromCFXRectF(rt);
   pFormFillEnv->Invalidate((FPDF_PAGE)pPage, rcPage.left, rcPage.bottom,
                            rcPage.right, rcPage.top);
 }
 
 void CPDFXFA_DocEnvironment::DisplayCaret(CXFA_FFWidget* hWidget,
-                                          FX_BOOL bVisible,
+                                          bool bVisible,
                                           const CFX_RectF* pRtAnchor) {
   if (!hWidget || !pRtAnchor || !m_pContext->GetXFADoc() ||
       !m_pContext->GetFormFillEnv() || !m_pContext->GetXFADocView())
     return;
 
   if (m_pContext->GetDocType() != DOCTYPE_DYNAMIC_XFA)
     return;
 
   CXFA_FFWidgetHandler* pWidgetHandler =
       m_pContext->GetXFADocView()->GetWidgetHandler();
@@ skipping 10 matching lines @@
 
   CPDFSDK_FormFillEnvironment* pFormFillEnv = m_pContext->GetFormFillEnv();
   if (!pFormFillEnv)
     return;
 
   CFX_FloatRect rcCaret = CFX_FloatRect::FromCFXRectF(*pRtAnchor);
   pFormFillEnv->DisplayCaret((FPDF_PAGE)pPage, bVisible, rcCaret.left,
                              rcCaret.top, rcCaret.right, rcCaret.bottom);
 }
 
-FX_BOOL CPDFXFA_DocEnvironment::GetPopupPos(CXFA_FFWidget* hWidget,
-                                            FX_FLOAT fMinPopup,
-                                            FX_FLOAT fMaxPopup,
-                                            const CFX_RectF& rtAnchor,
-                                            CFX_RectF& rtPopup) {
+bool CPDFXFA_DocEnvironment::GetPopupPos(CXFA_FFWidget* hWidget,
+                                         FX_FLOAT fMinPopup,
+                                         FX_FLOAT fMaxPopup,
+                                         const CFX_RectF& rtAnchor,
+                                         CFX_RectF& rtPopup) {
   if (!hWidget)
-    return FALSE;
+    return false;
 
   CXFA_FFPageView* pXFAPageView = hWidget->GetPageView();
   if (!pXFAPageView)
-    return FALSE;
+    return false;
 
   CPDFXFA_Page* pPage = m_pContext->GetXFAPage(pXFAPageView);
   if (!pPage)
-    return FALSE;
+    return false;
 
   CXFA_WidgetAcc* pWidgetAcc = hWidget->GetDataAcc();
   int nRotate = pWidgetAcc->GetRotate();
   CPDFSDK_FormFillEnvironment* pFormFillEnv = m_pContext->GetFormFillEnv();
   if (!pFormFillEnv)
-    return FALSE;
+    return false;
 
   FS_RECTF pageViewRect = {0.0f, 0.0f, 0.0f, 0.0f};
   pFormFillEnv->GetPageViewRect(pPage, pageViewRect);
 
   int t1;
   int t2;
   CFX_FloatRect rcAnchor = CFX_FloatRect::FromCFXRectF(rtAnchor);
   switch (nRotate) {
     case 90: {
       t1 = (int)(pageViewRect.right - rcAnchor.right);
@@ skipping 22 matching lines @@
       t2 = (int)(rcAnchor.bottom - pageViewRect.bottom);
       if (rcAnchor.right > pageViewRect.right)
         rtPopup.left -= rcAnchor.right - pageViewRect.right;
       break;
     }
   }
 
   int t;
   uint32_t dwPos;
   if (t1 <= 0 && t2 <= 0)
-    return FALSE;
+    return false;
   if (t1 <= 0) {
     t = t2;
     dwPos = 1;
   } else if (t2 <= 0) {
     t = t1;
     dwPos = 0;
   } else if (t1 > t2) {
     t = t1;
     dwPos = 0;
   } else {
@@ skipping 29 matching lines @@
       } else {
         rtPopup.top = -fPopupHeight;
         rtPopup.height = fPopupHeight;
       }
       break;
     }
     default:
       break;
   }
 
-  return TRUE;
+  return true;
 }
 
-FX_BOOL CPDFXFA_DocEnvironment::PopupMenu(CXFA_FFWidget* hWidget,
-                                          CFX_PointF ptPopup) {
+bool CPDFXFA_DocEnvironment::PopupMenu(CXFA_FFWidget* hWidget,
+                                       CFX_PointF ptPopup) {
   if (!hWidget)
-    return FALSE;
+    return false;
 
   CXFA_FFPageView* pXFAPageView = hWidget->GetPageView();
   if (!pXFAPageView)
-    return FALSE;
+    return false;
 
   CPDFXFA_Page* pPage = m_pContext->GetXFAPage(pXFAPageView);
   if (!pPage)
-    return FALSE;
+    return false;
 
   CPDFSDK_FormFillEnvironment* pFormFillEnv = m_pContext->GetFormFillEnv();
   if (!pFormFillEnv)
-    return FALSE;
+    return false;
 
   int menuFlag = 0;
   if (hWidget->CanUndo())
     menuFlag |= FXFA_MENU_UNDO;
   if (hWidget->CanRedo())
     menuFlag |= FXFA_MENU_REDO;
   if (hWidget->CanPaste())
     menuFlag |= FXFA_MENU_PASTE;
   if (hWidget->CanCopy())
     menuFlag |= FXFA_MENU_COPY;
@@ skipping 103 matching lines @@
       iCurPage >= m_pContext->GetFormFillEnv()->GetPageCount()) {
     return;
   }
 
   CPDFSDK_FormFillEnvironment* pFormFillEnv = m_pContext->GetFormFillEnv();
   if (!pFormFillEnv)
     return;
   pFormFillEnv->SetCurrentPage(this, iCurPage);
 }
 
-FX_BOOL CPDFXFA_DocEnvironment::IsCalculationsEnabled(CXFA_FFDoc* hDoc) {
+bool CPDFXFA_DocEnvironment::IsCalculationsEnabled(CXFA_FFDoc* hDoc) {
   if (hDoc != m_pContext->GetXFADoc() || !m_pContext->GetFormFillEnv())
-    return FALSE;
+    return false;
   if (m_pContext->GetFormFillEnv()->GetInterForm()) {
     return m_pContext->GetFormFillEnv()
         ->GetInterForm()
         ->IsXfaCalculateEnabled();
   }
-  return FALSE;
+  return false;
 }
 
 void CPDFXFA_DocEnvironment::SetCalculationsEnabled(CXFA_FFDoc* hDoc,
-                                                    FX_BOOL bEnabled) {
+                                                    bool bEnabled) {
   if (hDoc != m_pContext->GetXFADoc() || !m_pContext->GetFormFillEnv())
     return;
   if (m_pContext->GetFormFillEnv()->GetInterForm()) {
     m_pContext->GetFormFillEnv()->GetInterForm()->XfaEnableCalculate(bEnabled);
   }
 }
 
 void CPDFXFA_DocEnvironment::GetTitle(CXFA_FFDoc* hDoc,
                                       CFX_WideString& wsTitle) {
   if (hDoc != m_pContext->GetXFADoc() || !m_pContext->GetPDFDoc())
@@ skipping 12 matching lines @@
                                       const CFX_WideString& wsTitle) {
   if (hDoc != m_pContext->GetXFADoc() || !m_pContext->GetPDFDoc())
     return;
 
   if (CPDF_Dictionary* pInfoDict = m_pContext->GetPDFDoc()->GetInfo())
     pInfoDict->SetFor("Title", new CPDF_String(wsTitle));
 }
 
 void CPDFXFA_DocEnvironment::ExportData(CXFA_FFDoc* hDoc,
                                         const CFX_WideString& wsFilePath,
-                                        FX_BOOL bXDP) {
+                                        bool bXDP) {
   if (hDoc != m_pContext->GetXFADoc())
     return;
 
   if (m_pContext->GetDocType() != DOCTYPE_DYNAMIC_XFA &&
       m_pContext->GetDocType() != DOCTYPE_STATIC_XFA) {
     return;
   }
 
   CPDFSDK_FormFillEnvironment* pFormFillEnv = m_pContext->GetFormFillEnv();
   if (!pFormFillEnv)
@@ skipping 95 matching lines @@
     return;
 
   CPDFSDK_FormFillEnvironment* pFormFillEnv = m_pContext->GetFormFillEnv();
   if (!pFormFillEnv)
     return;
 
   CFX_WideStringC str(bsURL.c_str());
   pFormFillEnv->GotoURL(this, str);
 }
 
-FX_BOOL CPDFXFA_DocEnvironment::IsValidationsEnabled(CXFA_FFDoc* hDoc) {
+bool CPDFXFA_DocEnvironment::IsValidationsEnabled(CXFA_FFDoc* hDoc) {
   if (hDoc != m_pContext->GetXFADoc() || !m_pContext->GetFormFillEnv())
-    return FALSE;
+    return false;
   if (m_pContext->GetFormFillEnv()->GetInterForm()) {
     return m_pContext->GetFormFillEnv()
         ->GetInterForm()
         ->IsXfaValidationsEnabled();
   }
-  return TRUE;
+  return true;
 }
 
 void CPDFXFA_DocEnvironment::SetValidationsEnabled(CXFA_FFDoc* hDoc,
-                                                   FX_BOOL bEnabled) {
+                                                   bool bEnabled) {
   if (hDoc != m_pContext->GetXFADoc() || !m_pContext->GetFormFillEnv())
     return;
   if (m_pContext->GetFormFillEnv()->GetInterForm()) {
     m_pContext->GetFormFillEnv()->GetInterForm()->XfaSetValidationsEnabled(
         bEnabled);
   }
 }
 
 void CPDFXFA_DocEnvironment::SetFocusWidget(CXFA_FFDoc* hDoc,
                                             CXFA_FFWidget* hWidget) {
@@ skipping 47 matching lines @@
     return 0;
 
   CPDFSDK_InterForm* pInterForm = m_pContext->GetFormFillEnv()->GetInterForm();
   if (!pInterForm)
     return 0;
 
   return ArgbEncode(pInterForm->GetHighlightAlpha(),
                     pInterForm->GetHighlightColor(FPDF_FORMFIELD_XFA));
 }
 
-FX_BOOL CPDFXFA_DocEnvironment::NotifySubmit(FX_BOOL bPrevOrPost) {
+bool CPDFXFA_DocEnvironment::NotifySubmit(bool bPrevOrPost) {
   if (bPrevOrPost)
     return OnBeforeNotifySubmit();
 
   OnAfterNotifySubmit();
-  return TRUE;
+  return true;
 }
 
-FX_BOOL CPDFXFA_DocEnvironment::OnBeforeNotifySubmit() {
+bool CPDFXFA_DocEnvironment::OnBeforeNotifySubmit() {
   if (m_pContext->GetDocType() != DOCTYPE_DYNAMIC_XFA &&
       m_pContext->GetDocType() != DOCTYPE_STATIC_XFA) {
-    return TRUE;
+    return true;
   }
 
   if (!m_pContext->GetXFADocView())
-    return TRUE;
+    return true;
 
   CXFA_FFWidgetHandler* pWidgetHandler =
       m_pContext->GetXFADocView()->GetWidgetHandler();
   if (!pWidgetHandler)
-    return TRUE;
+    return true;
 
   std::unique_ptr<CXFA_WidgetAccIterator> pWidgetAccIterator(
       m_pContext->GetXFADocView()->CreateWidgetAccIterator());
   if (pWidgetAccIterator) {
     CXFA_EventParam Param;
     Param.m_eType = XFA_EVENT_PreSubmit;
     while (CXFA_WidgetAcc* pWidgetAcc = pWidgetAccIterator->MoveToNext())
       pWidgetHandler->ProcessEvent(pWidgetAcc, &Param);
   }
 
   pWidgetAccIterator.reset(
       m_pContext->GetXFADocView()->CreateWidgetAccIterator());
   if (!pWidgetAccIterator)
-    return TRUE;
+    return true;
 
   CXFA_WidgetAcc* pWidgetAcc = pWidgetAccIterator->MoveToNext();
   pWidgetAcc = pWidgetAccIterator->MoveToNext();
   while (pWidgetAcc) {
     int fRet = pWidgetAcc->ProcessValidate(-1);
     if (fRet == XFA_EVENTERROR_Error) {
       CPDFSDK_FormFillEnvironment* pFormFillEnv = m_pContext->GetFormFillEnv();
       if (!pFormFillEnv)
-        return FALSE;
+        return false;
 
       CFX_WideString ws;
       ws.FromLocal(IDS_XFA_Validate_Input);
       CFX_ByteString bs = ws.UTF16LE_Encode();
       int len = bs.GetLength();
       pFormFillEnv->Alert((FPDF_WIDESTRING)bs.GetBuffer(len),
                           (FPDF_WIDESTRING)L"", 0, 1);
       bs.ReleaseBuffer(len);
-      return FALSE;
+      return false;
     }
     pWidgetAcc = pWidgetAccIterator->MoveToNext();
   }
   m_pContext->GetXFADocView()->UpdateDocView();
 
-  return TRUE;
+  return true;
 }
 
 void CPDFXFA_DocEnvironment::OnAfterNotifySubmit() {
   if (m_pContext->GetDocType() != DOCTYPE_DYNAMIC_XFA &&
       m_pContext->GetDocType() != DOCTYPE_STATIC_XFA)
     return;
 
   if (!m_pContext->GetXFADocView())
     return;
 
@@ skipping 10 matching lines @@
   CXFA_EventParam Param;
   Param.m_eType = XFA_EVENT_PostSubmit;
   CXFA_WidgetAcc* pWidgetAcc = pWidgetAccIterator->MoveToNext();
   while (pWidgetAcc) {
     pWidgetHandler->ProcessEvent(pWidgetAcc, &Param);
     pWidgetAcc = pWidgetAccIterator->MoveToNext();
   }
   m_pContext->GetXFADocView()->UpdateDocView();
 }
 
-FX_BOOL CPDFXFA_DocEnvironment::SubmitData(CXFA_FFDoc* hDoc,
-                                           CXFA_Submit submit) {
-  if (!NotifySubmit(TRUE) || !m_pContext->GetXFADocView())
-    return FALSE;
+bool CPDFXFA_DocEnvironment::SubmitData(CXFA_FFDoc* hDoc, CXFA_Submit submit) {
+  if (!NotifySubmit(true) || !m_pContext->GetXFADocView())
+    return false;
 
   m_pContext->GetXFADocView()->UpdateDocView();
-  FX_BOOL ret = SubmitDataInternal(hDoc, submit);
-  NotifySubmit(FALSE);
+  bool ret = SubmitDataInternal(hDoc, submit);
+  NotifySubmit(false);
   return ret;
 }
 
 IFX_SeekableReadStream* CPDFXFA_DocEnvironment::OpenLinkedFile(
     CXFA_FFDoc* hDoc,
     const CFX_WideString& wsLink) {
   CPDFSDK_FormFillEnvironment* pFormFillEnv = m_pContext->GetFormFillEnv();
   if (!pFormFillEnv)
     return nullptr;
 
   CFX_ByteString bs = wsLink.UTF16LE_Encode();
   int len = bs.GetLength();
   FPDF_FILEHANDLER* pFileHandler =
       pFormFillEnv->OpenFile(0, (FPDF_WIDESTRING)bs.GetBuffer(len), "rb");
   bs.ReleaseBuffer(len);
   if (!pFileHandler)
     return nullptr;
 
   return new CFPDF_FileStream(pFileHandler);
 }
 
-FX_BOOL CPDFXFA_DocEnvironment::ExportSubmitFile(FPDF_FILEHANDLER* pFileHandler,
-                                                 int fileType,
-                                                 FPDF_DWORD encodeType,
-                                                 FPDF_DWORD flag) {
+bool CPDFXFA_DocEnvironment::ExportSubmitFile(FPDF_FILEHANDLER* pFileHandler,
+                                              int fileType,
+                                              FPDF_DWORD encodeType,
+                                              FPDF_DWORD flag) {
   if (!m_pContext->GetXFADocView())
-    return FALSE;
+    return false;
 
   CFX_ByteString content;
   CPDFSDK_FormFillEnvironment* pFormFillEnv = m_pContext->GetFormFillEnv();
   if (!pFormFillEnv)
-    return FALSE;
+    return false;
 
   CFPDF_FileStream fileStream(pFileHandler);
   if (fileType == FXFA_SAVEAS_XML) {
     const char kContent[] = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\r\n";
     fileStream.WriteBlock(kContent, 0, strlen(kContent));
     m_pContext->GetXFADoc()->SavePackage(XFA_HASHCODE_Data, &fileStream,
                                          nullptr);
-    return TRUE;
+    return true;
   }
 
   if (fileType != FXFA_SAVEAS_XDP)
-    return TRUE;
+    return true;
 
   if (!flag) {
     flag = FXFA_CONFIG | FXFA_TEMPLATE | FXFA_LOCALESET | FXFA_DATASETS |
            FXFA_XMPMETA | FXFA_XFDF | FXFA_FORM;
   }
   if (!m_pContext->GetPDFDoc()) {
     fileStream.Flush();
-    return FALSE;
+    return false;
   }
 
   CPDF_Dictionary* pRoot = m_pContext->GetPDFDoc()->GetRoot();
   if (!pRoot) {
     fileStream.Flush();
-    return FALSE;
+    return false;
   }
 
   CPDF_Dictionary* pAcroForm = pRoot->GetDictFor("AcroForm");
   if (!pAcroForm) {
     fileStream.Flush();
-    return FALSE;
+    return false;
   }
 
   CPDF_Array* pArray = ToArray(pAcroForm->GetObjectFor("XFA"));
   if (!pArray) {
     fileStream.Flush();
-    return FALSE;
+    return false;
   }
 
   int size = pArray->GetCount();
   for (int i = 1; i < size; i += 2) {
     CPDF_Object* pPDFObj = pArray->GetObjectAt(i);
     CPDF_Object* pPrePDFObj = pArray->GetObjectAt(i - 1);
     if (!pPrePDFObj->IsString())
       continue;
     if (!pPDFObj->IsReference())
       continue;
@@ skipping 18 matching lines @@
     if (pPrePDFObj->GetString() == "form") {
       m_pContext->GetXFADoc()->SavePackage(XFA_HASHCODE_Form, &fileStream,
                                            nullptr);
     } else if (pPrePDFObj->GetString() == "datasets") {
       m_pContext->GetXFADoc()->SavePackage(XFA_HASHCODE_Datasets, &fileStream,
                                            nullptr);
     } else {
       // PDF,creator.
     }
   }
-  return TRUE;
+  return true;
 }
 
 void CPDFXFA_DocEnvironment::ToXFAContentFlags(CFX_WideString csSrcContent,
                                                FPDF_DWORD& flag) {
   if (csSrcContent.Find(L" config ", 0) != -1)
     flag |= FXFA_CONFIG;
   if (csSrcContent.Find(L" template ", 0) != -1)
     flag |= FXFA_TEMPLATE;
   if (csSrcContent.Find(L" localeSet ", 0) != -1)
     flag |= FXFA_LOCALESET;
   if (csSrcContent.Find(L" datasets ", 0) != -1)
     flag |= FXFA_DATASETS;
   if (csSrcContent.Find(L" xmpmeta ", 0) != -1)
     flag |= FXFA_XMPMETA;
   if (csSrcContent.Find(L" xfdf ", 0) != -1)
     flag |= FXFA_XFDF;
   if (csSrcContent.Find(L" form ", 0) != -1)
     flag |= FXFA_FORM;
   if (flag == 0) {
     flag = FXFA_CONFIG | FXFA_TEMPLATE | FXFA_LOCALESET | FXFA_DATASETS |
            FXFA_XMPMETA | FXFA_XFDF | FXFA_FORM;
   }
 }
 
-FX_BOOL CPDFXFA_DocEnvironment::MailToInfo(CFX_WideString& csURL,
-                                           CFX_WideString& csToAddress,
-                                           CFX_WideString& csCCAddress,
-                                           CFX_WideString& csBCCAddress,
-                                           CFX_WideString& csSubject,
-                                           CFX_WideString& csMsg) {
+bool CPDFXFA_DocEnvironment::MailToInfo(CFX_WideString& csURL,
+                                        CFX_WideString& csToAddress,
+                                        CFX_WideString& csCCAddress,
+                                        CFX_WideString& csBCCAddress,
+                                        CFX_WideString& csSubject,
+                                        CFX_WideString& csMsg) {
   CFX_WideString srcURL = csURL;
   srcURL.TrimLeft();
   if (srcURL.Left(7).CompareNoCase(L"mailto:") != 0)
-    return FALSE;
+    return false;
 
   int pos = srcURL.Find(L'?', 0);
   CFX_WideString tmp;
   if (pos == -1) {
     pos = srcURL.Find(L'@', 0);
     if (pos == -1)
-      return FALSE;
+      return false;
 
     tmp = srcURL.Right(csURL.GetLength() - 7);
   } else {
     tmp = srcURL.Left(pos);
     tmp = tmp.Right(tmp.GetLength() - 7);
   }
   tmp.TrimLeft();
   tmp.TrimRight();
 
   csToAddress = tmp;
@@ skipping 25 matching lines @@
     } else if (tmp.GetLength() >= 5 &&
                tmp.Left(5).CompareNoCase(L"body=") == 0) {
       tmp = tmp.Right(tmp.GetLength() - 5);
       csMsg += tmp;
     }
     srcURL = (pos == -1) ? L"" : srcURL.Right(csURL.GetLength() - (pos + 1));
   }
   csToAddress.Replace(L",", L";");
   csCCAddress.Replace(L",", L";");
   csBCCAddress.Replace(L",", L";");
-  return TRUE;
+  return true;
 }
 
-FX_BOOL CPDFXFA_DocEnvironment::SubmitDataInternal(CXFA_FFDoc* hDoc,
-                                                   CXFA_Submit submit) {
+bool CPDFXFA_DocEnvironment::SubmitDataInternal(CXFA_FFDoc* hDoc,
+                                                CXFA_Submit submit) {
   CPDFSDK_FormFillEnvironment* pFormFillEnv = m_pContext->GetFormFillEnv();
   if (!pFormFillEnv)
-    return FALSE;
+    return false;
 
   CFX_WideStringC csURLC;
   submit.GetSubmitTarget(csURLC);
   CFX_WideString csURL(csURLC);
   if (csURL.IsEmpty()) {
     CFX_WideString ws;
     ws.FromLocal("Submit cancelled.");
     CFX_ByteString bs = ws.UTF16LE_Encode();
     int len = bs.GetLength();
     pFormFillEnv->Alert((FPDF_WIDESTRING)bs.GetBuffer(len),
                         (FPDF_WIDESTRING)L"", 0, 4);
     bs.ReleaseBuffer(len);
-    return FALSE;
+    return false;
   }
 
   FPDF_FILEHANDLER* pFileHandler = nullptr;
   int fileFlag = -1;
   switch (submit.GetSubmitFormat()) {
     case XFA_ATTRIBUTEENUM_Xdp: {
       CFX_WideStringC csContentC;
       submit.GetSubmitXDPContent(csContentC);
       CFX_WideString csContent;
       csContent = csContentC;
@@ skipping 21 matching lines @@
       break;
     case XFA_ATTRIBUTEENUM_Urlencoded:
       pFileHandler = pFormFillEnv->OpenFile(FXFA_SAVEAS_XML, nullptr, "wb");
       fileFlag = FXFA_SAVEAS_XML;
       ExportSubmitFile(pFileHandler, FXFA_SAVEAS_XML, 0, FXFA_XFA_ALL);
       break;
     default:
       return false;
   }
   if (!pFileHandler)
-    return FALSE;
+    return false;
   if (csURL.Left(7).CompareNoCase(L"mailto:") == 0) {
     CFX_WideString csToAddress;
     CFX_WideString csCCAddress;
     CFX_WideString csBCCAddress;
     CFX_WideString csSubject;
     CFX_WideString csMsg;
     if (!MailToInfo(csURL, csToAddress, csCCAddress, csBCCAddress, csSubject,
                     csMsg)) {
-      return FALSE;
+      return false;
     }
     CFX_ByteString bsTo = CFX_WideString(csToAddress).UTF16LE_Encode();
     CFX_ByteString bsCC = CFX_WideString(csCCAddress).UTF16LE_Encode();
     CFX_ByteString bsBcc = CFX_WideString(csBCCAddress).UTF16LE_Encode();
     CFX_ByteString bsSubject = CFX_WideString(csSubject).UTF16LE_Encode();
     CFX_ByteString bsMsg = CFX_WideString(csMsg).UTF16LE_Encode();
     FPDF_WIDESTRING pTo = (FPDF_WIDESTRING)bsTo.GetBuffer(bsTo.GetLength());
     FPDF_WIDESTRING pCC = (FPDF_WIDESTRING)bsCC.GetBuffer(bsCC.GetLength());
     FPDF_WIDESTRING pBcc = (FPDF_WIDESTRING)bsBcc.GetBuffer(bsBcc.GetLength());
     FPDF_WIDESTRING pSubject =
         (FPDF_WIDESTRING)bsSubject.GetBuffer(bsSubject.GetLength());
     FPDF_WIDESTRING pMsg = (FPDF_WIDESTRING)bsMsg.GetBuffer(bsMsg.GetLength());
     pFormFillEnv->EmailTo(pFileHandler, pTo, pSubject, pCC, pBcc, pMsg);
     bsTo.ReleaseBuffer();
     bsCC.ReleaseBuffer();
     bsBcc.ReleaseBuffer();
     bsSubject.ReleaseBuffer();
     bsMsg.ReleaseBuffer();
   } else {
     // HTTP or FTP
     CFX_WideString ws;
     CFX_ByteString bs = csURL.UTF16LE_Encode();
     int len = bs.GetLength();
     pFormFillEnv->UploadTo(pFileHandler, fileFlag,
                            (FPDF_WIDESTRING)bs.GetBuffer(len));
     bs.ReleaseBuffer(len);
   }
-  return TRUE;
+  return true;
 }
 
-FX_BOOL CPDFXFA_DocEnvironment::SetGlobalProperty(
+bool CPDFXFA_DocEnvironment::SetGlobalProperty(
     CXFA_FFDoc* hDoc,
     const CFX_ByteStringC& szPropName,
     CFXJSE_Value* pValue) {
   if (hDoc != m_pContext->GetXFADoc())
-    return FALSE;
+    return false;
 
   if (m_pContext->GetFormFillEnv() &&
       m_pContext->GetFormFillEnv()->GetJSRuntime()) {
     return m_pContext->GetFormFillEnv()->GetJSRuntime()->SetValueByName(
         szPropName, pValue);
   }
-  return FALSE;
+  return false;
 }
 
-FX_BOOL CPDFXFA_DocEnvironment::GetGlobalProperty(
+bool CPDFXFA_DocEnvironment::GetGlobalProperty(
     CXFA_FFDoc* hDoc,
     const CFX_ByteStringC& szPropName,
     CFXJSE_Value* pValue) {
   if (hDoc != m_pContext->GetXFADoc())
-    return FALSE;
+    return false;
   if (!m_pContext->GetFormFillEnv() ||
       !m_pContext->GetFormFillEnv()->GetJSRuntime()) {
-    return FALSE;
+    return false;
   }
 
   CPDFSDK_FormFillEnvironment* pFormFillEnv = m_pContext->GetFormFillEnv();
   if (!m_pJSContext)
     m_pJSContext = pFormFillEnv->GetJSRuntime()->NewContext();
 
   return pFormFillEnv->GetJSRuntime()->GetValueByName(szPropName, pValue);
 }