Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: fpdfsdk/javascript/JS_Runtime_Stub.cpp

Issue 2453683011: Remove FX_BOOL from fpdfsdk. (Closed)
Patch Set: Regenerate patch after rebase. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « fpdfsdk/javascript/JS_GlobalData.cpp ('k') | fpdfsdk/javascript/PublicMethods.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/javascript/JS_Runtime_Stub.cpp
diff --git a/fpdfsdk/javascript/JS_Runtime_Stub.cpp b/fpdfsdk/javascript/JS_Runtime_Stub.cpp
index e7853fba7a690756bae778160914715c1c6aad39..1daee4d734144d10bfd66c92db337122a7450a26 100644
--- a/fpdfsdk/javascript/JS_Runtime_Stub.cpp
+++ b/fpdfsdk/javascript/JS_Runtime_Stub.cpp
@@ -16,9 +16,8 @@ class CJS_ContextStub final : public IJS_Context {
~CJS_ContextStub() override {}
// IJS_Context:
- FX_BOOL RunScript(const CFX_WideString& script,
- CFX_WideString* info) override {
- return FALSE;
+ bool RunScript(const CFX_WideString& script, CFX_WideString* info) override {
+ return false;
}
void OnApp_Init() override {}
@@ -33,82 +32,82 @@ class CJS_ContextStub final : public IJS_Context {
void OnPage_Close(CPDFSDK_FormFillEnvironment* pFormFillEnv) override {}
void OnPage_InView(CPDFSDK_FormFillEnvironment* pFormFillEnv) override {}
void OnPage_OutView(CPDFSDK_FormFillEnvironment* pFormFillEnv) override {}
- void OnField_MouseDown(FX_BOOL bModifier,
- FX_BOOL bShift,
+ void OnField_MouseDown(bool bModifier,
+ bool bShift,
CPDF_FormField* pTarget) override {}
- void OnField_MouseEnter(FX_BOOL bModifier,
- FX_BOOL bShift,
+ void OnField_MouseEnter(bool bModifier,
+ bool bShift,
CPDF_FormField* pTarget) override {}
- void OnField_MouseExit(FX_BOOL bModifier,
- FX_BOOL bShift,
+ void OnField_MouseExit(bool bModifier,
+ bool bShift,
CPDF_FormField* pTarget) override {}
- void OnField_MouseUp(FX_BOOL bModifier,
- FX_BOOL bShift,
+ void OnField_MouseUp(bool bModifier,
+ bool bShift,
CPDF_FormField* pTarget) override {}
- void OnField_Focus(FX_BOOL bModifier,
- FX_BOOL bShift,
+ void OnField_Focus(bool bModifier,
+ bool bShift,
CPDF_FormField* pTarget,
const CFX_WideString& Value) override {}
- void OnField_Blur(FX_BOOL bModifier,
- FX_BOOL bShift,
+ void OnField_Blur(bool bModifier,
+ bool bShift,
CPDF_FormField* pTarget,
const CFX_WideString& Value) override {}
void OnField_Calculate(CPDF_FormField* pSource,
CPDF_FormField* pTarget,
CFX_WideString& Value,
- FX_BOOL& bRc) override {}
+ bool& bRc) override {}
void OnField_Format(CPDF_FormField* pTarget,
CFX_WideString& Value,
- FX_BOOL bWillCommit) override {}
+ bool bWillCommit) override {}
void OnField_Keystroke(CFX_WideString& strChange,
const CFX_WideString& strChangeEx,
- FX_BOOL KeyDown,
- FX_BOOL bModifier,
+ bool KeyDown,
+ bool bModifier,
int& nSelEnd,
int& nSelStart,
- FX_BOOL bShift,
+ bool bShift,
CPDF_FormField* pTarget,
CFX_WideString& Value,
- FX_BOOL bWillCommit,
- FX_BOOL bFieldFull,
- FX_BOOL& bRc) override {}
+ bool bWillCommit,
+ bool bFieldFull,
+ bool& bRc) override {}
void OnField_Validate(CFX_WideString& strChange,
const CFX_WideString& strChangeEx,
- FX_BOOL bKeyDown,
- FX_BOOL bModifier,
- FX_BOOL bShift,
+ bool bKeyDown,
+ bool bModifier,
+ bool bShift,
CPDF_FormField* pTarget,
CFX_WideString& Value,
- FX_BOOL& bRc) override {}
- void OnScreen_Focus(FX_BOOL bModifier,
- FX_BOOL bShift,
+ bool& bRc) override {}
+ void OnScreen_Focus(bool bModifier,
+ bool bShift,
CPDFSDK_Annot* pScreen) override {}
- void OnScreen_Blur(FX_BOOL bModifier,
- FX_BOOL bShift,
+ void OnScreen_Blur(bool bModifier,
+ bool bShift,
CPDFSDK_Annot* pScreen) override {}
- void OnScreen_Open(FX_BOOL bModifier,
- FX_BOOL bShift,
+ void OnScreen_Open(bool bModifier,
+ bool bShift,
CPDFSDK_Annot* pScreen) override {}
- void OnScreen_Close(FX_BOOL bModifier,
- FX_BOOL bShift,
+ void OnScreen_Close(bool bModifier,
+ bool bShift,
CPDFSDK_Annot* pScreen) override {}
- void OnScreen_MouseDown(FX_BOOL bModifier,
- FX_BOOL bShift,
+ void OnScreen_MouseDown(bool bModifier,
+ bool bShift,
CPDFSDK_Annot* pScreen) override {}
- void OnScreen_MouseUp(FX_BOOL bModifier,
- FX_BOOL bShift,
+ void OnScreen_MouseUp(bool bModifier,
+ bool bShift,
CPDFSDK_Annot* pScreen) override {}
- void OnScreen_MouseEnter(FX_BOOL bModifier,
- FX_BOOL bShift,
+ void OnScreen_MouseEnter(bool bModifier,
+ bool bShift,
CPDFSDK_Annot* pScreen) override {}
- void OnScreen_MouseExit(FX_BOOL bModifier,
- FX_BOOL bShift,
+ void OnScreen_MouseExit(bool bModifier,
+ bool bShift,
CPDFSDK_Annot* pScreen) override {}
- void OnScreen_InView(FX_BOOL bModifier,
- FX_BOOL bShift,
+ void OnScreen_InView(bool bModifier,
+ bool bShift,
CPDFSDK_Annot* pScreen) override {}
- void OnScreen_OutView(FX_BOOL bModifier,
- FX_BOOL bShift,
+ void OnScreen_OutView(bool bModifier,
+ bool bShift,
CPDFSDK_Annot* pScreen) override {}
void OnBookmark_MouseUp(CPDF_Bookmark* pBookMark) override {}
void OnLink_MouseUp(CPDFSDK_FormFillEnvironment* pFormFillEnv) override {}
@@ -139,12 +138,12 @@ class CJS_RuntimeStub final : public IJS_Runtime {
}
#ifdef PDF_ENABLE_XFA
- FX_BOOL GetValueByName(const CFX_ByteStringC&, CFXJSE_Value*) override {
- return FALSE;
+ bool GetValueByName(const CFX_ByteStringC&, CFXJSE_Value*) override {
+ return false;
}
- FX_BOOL SetValueByName(const CFX_ByteStringC&, CFXJSE_Value*) override {
- return FALSE;
+ bool SetValueByName(const CFX_ByteStringC&, CFXJSE_Value*) override {
+ return false;
}
#endif // PDF_ENABLE_XFA
« no previous file with comments | « fpdfsdk/javascript/JS_GlobalData.cpp ('k') | fpdfsdk/javascript/PublicMethods.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698