Web Animations: consistent naming for parent style checkers

Web Animations: consistent naming for parent style checkers

Interpolations to or from 'inherit' check if the parent style has
changed. The checking classes now have a consistent naming convention:
Inherited<property>Checker.

BUG=624636
Committed: https://crrev.com/071321870a524994c10d0c7a89dd5db533712a8d
Cr-Commit-Position: refs/heads/master@{#427649}

[Eric Willigers, 2016-10-25 23:37:16]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 23:37:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eric Willigers, 2016-10-25 23:38:17]

ericwilligers@chromium.org changed reviewers:
+ alancutter@chromium.org

[Eric Willigers, 2016-10-25 23:38:17]

This CL was prepared with no manual edits:

sed -i -e "s/InheritedShapeChecker/ParentShapeChecker/g"
CSSBasicShapeInterpolationType.cpp
sed -i -e "s/InheritedSideNumbersChecker/ParentSideNumbersChecker/g"
CSSBorderImageLengthBoxInterpolationType.cpp
sed -i -e "s/InheritedFilterListChecker/ParentFilterListChecker/g"
CSSFilterListInterpolationType.cpp
sed -i -e "s/InheritedFontSizeChecker/ParentFontSizeChecker/g"
CSSFontSizeInterpolationType.cpp
sed -i -e "s/InheritedSliceTypesChecker/ParentSliceTypesChecker/g"
CSSImageSliceInterpolationType.cpp
sed -i -e "s/InheritedRotationTypeChecker/ParentRotationTypeChecker/g"
CSSOffsetRotationInterpolationType.cpp
sed -i -e "s/InheritedRotationChecker/ParentRotationChecker/g"
CSSRotateInterpolationType.cpp
sed -i -e "s/InheritedSizeListChecker/ParentSizeListChecker/g"
CSSSizeListInterpolationType.cpp
sed -i -e "s/InheritedIndentModeChecker/ParentIndentModeChecker/g"
CSSTextIndentInterpolationType.cpp
sed -i -e "s/InheritedTransformChecker/ParentTransformChecker/g"
CSSTransformInterpolationType.cpp
git cl format

[alancutter (OOO until 2018), 2016-10-25 23:51:43]

On 2016/10/25 at 23:38:17, ericwilligers wrote:
> This CL was prepared with no manual edits:
> 
> sed -i -e "s/InheritedShapeChecker/ParentShapeChecker/g"
CSSBasicShapeInterpolationType.cpp
> sed -i -e "s/InheritedSideNumbersChecker/ParentSideNumbersChecker/g"
CSSBorderImageLengthBoxInterpolationType.cpp
> sed -i -e "s/InheritedFilterListChecker/ParentFilterListChecker/g"
CSSFilterListInterpolationType.cpp
> sed -i -e "s/InheritedFontSizeChecker/ParentFontSizeChecker/g"
CSSFontSizeInterpolationType.cpp
> sed -i -e "s/InheritedSliceTypesChecker/ParentSliceTypesChecker/g"
CSSImageSliceInterpolationType.cpp
> sed -i -e "s/InheritedRotationTypeChecker/ParentRotationTypeChecker/g"
CSSOffsetRotationInterpolationType.cpp
> sed -i -e "s/InheritedRotationChecker/ParentRotationChecker/g"
CSSRotateInterpolationType.cpp
> sed -i -e "s/InheritedSizeListChecker/ParentSizeListChecker/g"
CSSSizeListInterpolationType.cpp
> sed -i -e "s/InheritedIndentModeChecker/ParentIndentModeChecker/g"
CSSTextIndentInterpolationType.cpp
> sed -i -e "s/InheritedTransformChecker/ParentTransformChecker/g"
CSSTransformInterpolationType.cpp
> git cl format

Given that these are used for "inherit" keyframes and the member and parameter
names already look like "inheritedTransform" we should probably name these
Inherited<Type>Checker.

[commit-bot: I haz the power, 2016-10-26 00:58:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 00:58:18]

Dry run: This issue passed the CQ dry run.

[Eric Willigers, 2016-10-26 01:22:54]

Patchset #2 (id:20001) has been deleted

[Eric Willigers, 2016-10-26 01:23:06]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[Eric Willigers, 2016-10-26 01:23:25]

Description was changed from

==========
Web Animations: consistent naming for parent style checkers

Interpolations to or from 'inherit' check if the parent style has
changed. The checking classes now have a consistent naming convention:
Parent<property>Checker.

BUG=624636
==========

to

==========
Web Animations: consistent naming for parent style checkers

Interpolations to or from 'inherit' check if the parent style has
changed. The checking classes now have a consistent naming convention:
Inherited<property>Checker.

BUG=624636
==========

[commit-bot: I haz the power, 2016-10-26 01:23:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eric Willigers, 2016-10-26 01:23:41]

On 2016/10/25 23:51:43, alancutter wrote:
> On 2016/10/25 at 23:38:17, ericwilligers wrote:
> > This CL was prepared with no manual edits:
> > 
> > sed -i -e "s/InheritedShapeChecker/ParentShapeChecker/g"
> CSSBasicShapeInterpolationType.cpp
> > sed -i -e "s/InheritedSideNumbersChecker/ParentSideNumbersChecker/g"
> CSSBorderImageLengthBoxInterpolationType.cpp
> > sed -i -e "s/InheritedFilterListChecker/ParentFilterListChecker/g"
> CSSFilterListInterpolationType.cpp
> > sed -i -e "s/InheritedFontSizeChecker/ParentFontSizeChecker/g"
> CSSFontSizeInterpolationType.cpp
> > sed -i -e "s/InheritedSliceTypesChecker/ParentSliceTypesChecker/g"
> CSSImageSliceInterpolationType.cpp
> > sed -i -e "s/InheritedRotationTypeChecker/ParentRotationTypeChecker/g"
> CSSOffsetRotationInterpolationType.cpp
> > sed -i -e "s/InheritedRotationChecker/ParentRotationChecker/g"
> CSSRotateInterpolationType.cpp
> > sed -i -e "s/InheritedSizeListChecker/ParentSizeListChecker/g"
> CSSSizeListInterpolationType.cpp
> > sed -i -e "s/InheritedIndentModeChecker/ParentIndentModeChecker/g"
> CSSTextIndentInterpolationType.cpp
> > sed -i -e "s/InheritedTransformChecker/ParentTransformChecker/g"
> CSSTransformInterpolationType.cpp
> > git cl format
> 
> Given that these are used for "inherit" keyframes and the member and parameter
> names already look like "inheritedTransform" we should probably name these
> Inherited<Type>Checker.

Done

[alancutter (OOO until 2018), 2016-10-26 01:42:28]

lgtm after changes.

https://codereview.chromium.org/2453573003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp
(right):

https://codereview.chromium.org/2453573003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp:64: return
wrapUnique(new InheritedAutosChecker(parentAutos));
Rename to inheritedAutos.

https://codereview.chromium.org/2453573003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/CSSScaleInterpolationType.cpp
(right):

https://codereview.chromium.org/2453573003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/CSSScaleInterpolationType.cpp:135:
conversionCheckers.append(InheritedScaleChecker::create(parentScale));
Rename to inheritedScale.

https://codereview.chromium.org/2453573003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp
(right):

https://codereview.chromium.org/2453573003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp:89:
cssProperty(), const_cast<ShadowList*>(parentShadowList)));  // Take ref.
Rename to inheritedShadowList.

https://codereview.chromium.org/2453573003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp
(right):

https://codereview.chromium.org/2453573003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp:23:
PassRefPtr<TranslateTransformOperation> parentTranslate) {
Rename to inheritedTransform.

[commit-bot: I haz the power, 2016-10-26 02:15:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 02:15:52]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Eric Willigers, 2016-10-26 02:57:36]

On 2016/10/26 01:42:28, alancutter wrote:
> lgtm after changes.
> 
>
https://codereview.chromium.org/2453573003/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp
> (right):
> 
>
https://codereview.chromium.org/2453573003/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp:64:
return
> wrapUnique(new InheritedAutosChecker(parentAutos));
> Rename to inheritedAutos.
> 
>
https://codereview.chromium.org/2453573003/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/animation/CSSScaleInterpolationType.cpp
> (right):
> 
>
https://codereview.chromium.org/2453573003/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/animation/CSSScaleInterpolationType.cpp:135:
> conversionCheckers.append(InheritedScaleChecker::create(parentScale));
> Rename to inheritedScale.
> 
>
https://codereview.chromium.org/2453573003/diff/40001/third_party/WebKit/Sour...
> File
third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp
> (right):
> 
>
https://codereview.chromium.org/2453573003/diff/40001/third_party/WebKit/Sour...
>
third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp:89:
> cssProperty(), const_cast<ShadowList*>(parentShadowList)));  // Take ref.
> Rename to inheritedShadowList.
> 
>
https://codereview.chromium.org/2453573003/diff/40001/third_party/WebKit/Sour...
> File
third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp
> (right):
> 
>
https://codereview.chromium.org/2453573003/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp:23:
> PassRefPtr<TranslateTransformOperation> parentTranslate) {
> Rename to inheritedTransform.

Done

[Eric Willigers, 2016-10-26 02:58:34]

https://codereview.chromium.org/2453573003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp
(right):

https://codereview.chromium.org/2453573003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp:64: return
wrapUnique(new InheritedAutosChecker(parentAutos));
On 2016/10/26 01:42:28, alancutter wrote:
> Rename to inheritedAutos.

Done.

https://codereview.chromium.org/2453573003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/CSSScaleInterpolationType.cpp
(right):

https://codereview.chromium.org/2453573003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/CSSScaleInterpolationType.cpp:135:
conversionCheckers.append(InheritedScaleChecker::create(parentScale));
On 2016/10/26 01:42:28, alancutter wrote:
> Rename to inheritedScale.

Done.

https://codereview.chromium.org/2453573003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp
(right):

https://codereview.chromium.org/2453573003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp:89:
cssProperty(), const_cast<ShadowList*>(parentShadowList)));  // Take ref.
On 2016/10/26 01:42:28, alancutter wrote:
> Rename to inheritedShadowList.

Done.

https://codereview.chromium.org/2453573003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp
(right):

https://codereview.chromium.org/2453573003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp:23:
PassRefPtr<TranslateTransformOperation> parentTranslate) {
On 2016/10/26 01:42:28, alancutter wrote:
> Rename to inheritedTransform.

inheritedTranslate

[Eric Willigers, 2016-10-26 02:59:18]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 02:59:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 04:06:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 04:06:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Eric Willigers, 2016-10-26 08:36:17]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2016-10-26 08:36:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2453573003/#ps60001
(title: "inheritedValue")

[commit-bot: I haz the power, 2016-10-26 08:36:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 09:40:23]

Description was changed from

==========
Web Animations: consistent naming for parent style checkers

Interpolations to or from 'inherit' check if the parent style has
changed. The checking classes now have a consistent naming convention:
Inherited<property>Checker.

BUG=624636
==========

to

==========
Web Animations: consistent naming for parent style checkers

Interpolations to or from 'inherit' check if the parent style has
changed. The checking classes now have a consistent naming convention:
Inherited<property>Checker.

BUG=624636
==========

[commit-bot: I haz the power, 2016-10-26 09:40:24]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-10-26 09:42:31]

Description was changed from

==========
Web Animations: consistent naming for parent style checkers

Interpolations to or from 'inherit' check if the parent style has
changed. The checking classes now have a consistent naming convention:
Inherited<property>Checker.

BUG=624636
==========

to

==========
Web Animations: consistent naming for parent style checkers

Interpolations to or from 'inherit' check if the parent style has
changed. The checking classes now have a consistent naming convention:
Inherited<property>Checker.

BUG=624636

Committed: https://crrev.com/071321870a524994c10d0c7a89dd5db533712a8d
Cr-Commit-Position: refs/heads/master@{#427649}
==========

[commit-bot: I haz the power, 2016-10-26 09:42:32]

Patchset 3 (id:??) landed as
https://crrev.com/071321870a524994c10d0c7a89dd5db533712a8d
Cr-Commit-Position: refs/heads/master@{#427649}