Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp

Issue 2453573003: Web Animations: consistent naming for parent style checkers (Closed)
Patch Set: inheritedValue Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp
diff --git a/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp
index 0027dee2f38b46f93554a2ea2c3d435b1e615958..fe3f489bd9c99961a932f6ca9258a10952ba33ce 100644
--- a/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp
+++ b/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp
@@ -76,15 +76,16 @@ class UnderlyingVisibilityChecker
const EVisibility m_visibility;
};
-class ParentVisibilityChecker : public InterpolationType::ConversionChecker {
+class InheritedVisibilityChecker : public InterpolationType::ConversionChecker {
public:
- static std::unique_ptr<ParentVisibilityChecker> create(
+ static std::unique_ptr<InheritedVisibilityChecker> create(
EVisibility visibility) {
- return wrapUnique(new ParentVisibilityChecker(visibility));
+ return wrapUnique(new InheritedVisibilityChecker(visibility));
}
private:
- ParentVisibilityChecker(EVisibility visibility) : m_visibility(visibility) {}
+ InheritedVisibilityChecker(EVisibility visibility)
+ : m_visibility(visibility) {}
bool isValid(const InterpolationEnvironment& environment,
const InterpolationValue& underlying) const final {
@@ -127,7 +128,7 @@ InterpolationValue CSSVisibilityInterpolationType::maybeConvertInherit(
return nullptr;
EVisibility inheritedVisibility = state.parentStyle()->visibility();
conversionCheckers.append(
- ParentVisibilityChecker::create(inheritedVisibility));
+ InheritedVisibilityChecker::create(inheritedVisibility));
return createVisibilityValue(inheritedVisibility);
}
« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698