Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp

Issue 2453573003: Web Animations: consistent naming for parent style checkers (Closed)
Patch Set: inheritedValue Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp
diff --git a/third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp
index 3c053b8fd196645e23281cf616af2766ac2a98ca..dccc91423ee309ee06384bbe21acb90c6a53c3f0 100644
--- a/third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp
+++ b/third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp
@@ -51,15 +51,16 @@ InterpolationValue CSSPathInterpolationType::maybeConvertInitial(
return PathInterpolationFunctions::convertValue(nullptr);
}
-class ParentPathChecker : public InterpolationType::ConversionChecker {
+class InheritedPathChecker : public InterpolationType::ConversionChecker {
public:
- static std::unique_ptr<ParentPathChecker> create(
+ static std::unique_ptr<InheritedPathChecker> create(
PassRefPtr<StylePath> stylePath) {
- return wrapUnique(new ParentPathChecker(std::move(stylePath)));
+ return wrapUnique(new InheritedPathChecker(std::move(stylePath)));
}
private:
- ParentPathChecker(PassRefPtr<StylePath> stylePath) : m_stylePath(stylePath) {}
+ InheritedPathChecker(PassRefPtr<StylePath> stylePath)
+ : m_stylePath(stylePath) {}
bool isValid(const InterpolationEnvironment& environment,
const InterpolationValue& underlying) const final {
@@ -78,7 +79,7 @@ InterpolationValue CSSPathInterpolationType::maybeConvertInherit(
return nullptr;
conversionCheckers.append(
- ParentPathChecker::create(state.parentStyle()->svgStyle().d()));
+ InheritedPathChecker::create(state.parentStyle()->svgStyle().d()));
return PathInterpolationFunctions::convertValue(
state.parentStyle()->svgStyle().d());
}

Powered by Google App Engine
This is Rietveld 408576698