Chromium Code Reviews| Index: chrome/android/webapk/shell_apk/AndroidManifest.xml |
| diff --git a/chrome/android/webapk/shell_apk/AndroidManifest.xml b/chrome/android/webapk/shell_apk/AndroidManifest.xml |
| index 7018924b0b85f499c6299b34bd83688ffa705cd9..f641ff8a9a4ab535ec853365a888c78de80a1d82 100644 |
| --- a/chrome/android/webapk/shell_apk/AndroidManifest.xml |
| +++ b/chrome/android/webapk/shell_apk/AndroidManifest.xml |
| @@ -47,7 +47,8 @@ |
| <meta-data android:name="org.chromium.webapk.shell_apk.themeColor" android:value="{{ theme_color }}" /> |
| <meta-data android:name="org.chromium.webapk.shell_apk.backgroundColor" android:value="{{ background_color }}" /> |
| <meta-data android:name="org.chromium.webapk.shell_apk.iconId" android:resource="@mipmap/app_icon" /> |
|
pkotwicz
2016/11/01 00:29:49
Nit: rename iconId -> bestIconId
Xi Han
2016/11/07 16:51:43
Done.
|
| - <meta-data android:name="org.chromium.webapk.shell_apk.iconUrl" android:value="{{ icon_url }}" /> |
| + <meta-data android:name="org.chromium.webapk.shell_apk.bestIconUrl" android:value="{{ best_icon_url }}" /> |
| + <meta-data android:name="org.chromium.webapk.shell_apk.iconUrls" android:value="{{ icon_urls }}" /> |
|
pkotwicz
2016/11/01 00:29:49
Nit: Move this line before all of the "best" <meta
Xi Han
2016/11/07 16:51:43
Done.
|
| <meta-data android:name="org.chromium.webapk.shell_apk.iconMurmur2Hash" android:value="{{ icon_murmur2_hash }}" /> |
|
pkotwicz
2016/11/01 00:29:49
Nit: Rename iconMurmur2Hash -> bestIconMurmur2Hash
Xi Han
2016/11/07 16:51:43
Done.
|
| <meta-data android:name="org.chromium.webapk.shell_apk.webManifestUrl" android:value="{{ web_manifest_url }}" /> |
| <service |