Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: chrome/android/webapk/shell_apk/AndroidManifest.xml

Issue 2453423002: Send all of the icon URLs listed in Web Manifest to WebAPK Server. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/webapk/shell_apk/AndroidManifest.xml
diff --git a/chrome/android/webapk/shell_apk/AndroidManifest.xml b/chrome/android/webapk/shell_apk/AndroidManifest.xml
index 7018924b0b85f499c6299b34bd83688ffa705cd9..f641ff8a9a4ab535ec853365a888c78de80a1d82 100644
--- a/chrome/android/webapk/shell_apk/AndroidManifest.xml
+++ b/chrome/android/webapk/shell_apk/AndroidManifest.xml
@@ -47,7 +47,8 @@
<meta-data android:name="org.chromium.webapk.shell_apk.themeColor" android:value="{{ theme_color }}" />
<meta-data android:name="org.chromium.webapk.shell_apk.backgroundColor" android:value="{{ background_color }}" />
<meta-data android:name="org.chromium.webapk.shell_apk.iconId" android:resource="@mipmap/app_icon" />
pkotwicz 2016/11/01 00:29:49 Nit: rename iconId -> bestIconId
Xi Han 2016/11/07 16:51:43 Done.
- <meta-data android:name="org.chromium.webapk.shell_apk.iconUrl" android:value="{{ icon_url }}" />
+ <meta-data android:name="org.chromium.webapk.shell_apk.bestIconUrl" android:value="{{ best_icon_url }}" />
+ <meta-data android:name="org.chromium.webapk.shell_apk.iconUrls" android:value="{{ icon_urls }}" />
pkotwicz 2016/11/01 00:29:49 Nit: Move this line before all of the "best" <meta
Xi Han 2016/11/07 16:51:43 Done.
<meta-data android:name="org.chromium.webapk.shell_apk.iconMurmur2Hash" android:value="{{ icon_murmur2_hash }}" />
pkotwicz 2016/11/01 00:29:49 Nit: Rename iconMurmur2Hash -> bestIconMurmur2Hash
Xi Han 2016/11/07 16:51:43 Done.
<meta-data android:name="org.chromium.webapk.shell_apk.webManifestUrl" android:value="{{ web_manifest_url }}" />
<service

Powered by Google App Engine
This is Rietveld 408576698