Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <?xml version="1.0" encoding="utf-8"?> | 1 <?xml version="1.0" encoding="utf-8"?> |
| 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. | 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. |
| 3 Use of this source code is governed by a BSD-style license that can be | 3 Use of this source code is governed by a BSD-style license that can be |
| 4 found in the LICENSE file. | 4 found in the LICENSE file. |
| 5 --> | 5 --> |
| 6 <manifest xmlns:android="http://schemas.android.com/apk/res/android" | 6 <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 7 xmlns:tools="http://schemas.android.com/tools" | 7 xmlns:tools="http://schemas.android.com/tools" |
| 8 package="{{ manifest_package }}" | 8 package="{{ manifest_package }}" |
| 9 android:versionCode="{{ version_code }}" | 9 android:versionCode="{{ version_code }}" |
| 10 android:versionName="{{ version_name }}" > | 10 android:versionName="{{ version_name }}" > |
| (...skipping 28 matching lines...) Expand all Loading... | |
| 39 <meta-data android:name="org.chromium.webapk.shell_apk.shellApkVersion" android:value="{{ shell_apk_version }}" /> | 39 <meta-data android:name="org.chromium.webapk.shell_apk.shellApkVersion" android:value="{{ shell_apk_version }}" /> |
| 40 <meta-data android:name="org.chromium.webapk.shell_apk.runtimeHost" andr oid:value="{{ runtime_host }}" /> | 40 <meta-data android:name="org.chromium.webapk.shell_apk.runtimeHost" andr oid:value="{{ runtime_host }}" /> |
| 41 <meta-data android:name="org.chromium.webapk.shell_apk.startUrl" android :value="{{ start_url }}" /> | 41 <meta-data android:name="org.chromium.webapk.shell_apk.startUrl" android :value="{{ start_url }}" /> |
| 42 <meta-data android:name="org.chromium.webapk.shell_apk.name" android:val ue="{{ name }}" /> | 42 <meta-data android:name="org.chromium.webapk.shell_apk.name" android:val ue="{{ name }}" /> |
| 43 <meta-data android:name="org.chromium.webapk.shell_apk.shortName" androi d:value="{{ short_name }}" /> | 43 <meta-data android:name="org.chromium.webapk.shell_apk.shortName" androi d:value="{{ short_name }}" /> |
| 44 <meta-data android:name="org.chromium.webapk.shell_apk.scope" android:va lue="{{ scope_url }}" /> | 44 <meta-data android:name="org.chromium.webapk.shell_apk.scope" android:va lue="{{ scope_url }}" /> |
| 45 <meta-data android:name="org.chromium.webapk.shell_apk.displayMode" andr oid:value="{{ display_mode }}" /> | 45 <meta-data android:name="org.chromium.webapk.shell_apk.displayMode" andr oid:value="{{ display_mode }}" /> |
| 46 <meta-data android:name="org.chromium.webapk.shell_apk.orientation" andr oid:value="{{ orientation }}" /> | 46 <meta-data android:name="org.chromium.webapk.shell_apk.orientation" andr oid:value="{{ orientation }}" /> |
| 47 <meta-data android:name="org.chromium.webapk.shell_apk.themeColor" andro id:value="{{ theme_color }}" /> | 47 <meta-data android:name="org.chromium.webapk.shell_apk.themeColor" andro id:value="{{ theme_color }}" /> |
| 48 <meta-data android:name="org.chromium.webapk.shell_apk.backgroundColor" android:value="{{ background_color }}" /> | 48 <meta-data android:name="org.chromium.webapk.shell_apk.backgroundColor" android:value="{{ background_color }}" /> |
| 49 <meta-data android:name="org.chromium.webapk.shell_apk.iconId" android:r esource="@mipmap/app_icon" /> | 49 <meta-data android:name="org.chromium.webapk.shell_apk.iconId" android:r esource="@mipmap/app_icon" /> |
|
pkotwicz
2016/11/01 00:29:49
Nit: rename iconId -> bestIconId
Xi Han
2016/11/07 16:51:43
Done.
| |
| 50 <meta-data android:name="org.chromium.webapk.shell_apk.iconUrl" android: value="{{ icon_url }}" /> | 50 <meta-data android:name="org.chromium.webapk.shell_apk.bestIconUrl" andr oid:value="{{ best_icon_url }}" /> |
| 51 <meta-data android:name="org.chromium.webapk.shell_apk.iconUrls" android :value="{{ icon_urls }}" /> | |
|
pkotwicz
2016/11/01 00:29:49
Nit: Move this line before all of the "best" <meta
Xi Han
2016/11/07 16:51:43
Done.
| |
| 51 <meta-data android:name="org.chromium.webapk.shell_apk.iconMurmur2Hash" android:value="{{ icon_murmur2_hash }}" /> | 52 <meta-data android:name="org.chromium.webapk.shell_apk.iconMurmur2Hash" android:value="{{ icon_murmur2_hash }}" /> |
|
pkotwicz
2016/11/01 00:29:49
Nit: Rename iconMurmur2Hash -> bestIconMurmur2Hash
Xi Han
2016/11/07 16:51:43
Done.
| |
| 52 <meta-data android:name="org.chromium.webapk.shell_apk.webManifestUrl" a ndroid:value="{{ web_manifest_url }}" /> | 53 <meta-data android:name="org.chromium.webapk.shell_apk.webManifestUrl" a ndroid:value="{{ web_manifest_url }}" /> |
| 53 <service | 54 <service |
| 54 android:name="org.chromium.webapk.shell_apk.WebApkServiceFactory" | 55 android:name="org.chromium.webapk.shell_apk.WebApkServiceFactory" |
| 55 android:exported="true" | 56 android:exported="true" |
| 56 tools:ignore="ExportedService"> | 57 tools:ignore="ExportedService"> |
| 57 <intent-filter> | 58 <intent-filter> |
| 58 <action android:name="android.intent.action.MAIN" /> | 59 <action android:name="android.intent.action.MAIN" /> |
| 59 <category android:name="android.intent.category.WEBAPK_API" /> | 60 <category android:name="android.intent.category.WEBAPK_API" /> |
| 60 </intent-filter> | 61 </intent-filter> |
| 61 </service> | 62 </service> |
| (...skipping 11 matching lines...) Expand all Loading... | |
| 73 android:process=":webapk_sandboxed_process1" | 74 android:process=":webapk_sandboxed_process1" |
| 74 android:exported="true" | 75 android:exported="true" |
| 75 tools:ignore="ExportedService"/> | 76 tools:ignore="ExportedService"/> |
| 76 <service android:name="org.chromium.webapk.shell_apk.WebApkSandboxedProc essService2" | 77 <service android:name="org.chromium.webapk.shell_apk.WebApkSandboxedProc essService2" |
| 77 android:isolatedProcess="true" | 78 android:isolatedProcess="true" |
| 78 android:process=":webapk_sandboxed_process2" | 79 android:process=":webapk_sandboxed_process2" |
| 79 android:exported="true" | 80 android:exported="true" |
| 80 tools:ignore="ExportedService"/> | 81 tools:ignore="ExportedService"/> |
| 81 </application> | 82 </application> |
| 82 </manifest> | 83 </manifest> |
| OLD | NEW |