Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java

Issue 2453423002: Send all of the icon URLs listed in Web Manifest to WebAPK Server. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java
diff --git a/chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java b/chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java
index 53c2cb7926d8d91528425c43d0ac22f32a2cbdfb..bf5152d07de5390cc33353685089e026c1b3cc12 100644
--- a/chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java
+++ b/chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java
@@ -20,4 +20,8 @@ public final class WebApkConstants {
public static final String EXTRA_SOURCE = "org.chromium.chrome.browser.webapp_source";
public static final String EXTRA_WEBAPK_PACKAGE_NAME =
"org.chromium.chrome.browser.webapk_package_name";
+
+ // We use ONE string to store all of the icon URLs in WebAPK's AndroidManifest.xml, and put a
+ // separator between them.
+ public static final String ICON_URL_SEPARATOR = "; ";
pkotwicz 2016/11/01 00:29:49 Can the separator be just ' '? I don't think that
Xi Han 2016/11/07 16:51:42 We definitely could only use a space, since space
}

Powered by Google App Engine
This is Rietveld 408576698