Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3421)

Unified Diff: chrome/android/webapk/shell_apk/BUILD.gn

Issue 2453423002: Send all of the icon URLs listed in Web Manifest to WebAPK Server. (Closed)
Patch Set: Remove best_icon_url and best_icon_hash from metadata, but add all icon urls and icon hashs in. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/webapk/shell_apk/BUILD.gn
diff --git a/chrome/android/webapk/shell_apk/BUILD.gn b/chrome/android/webapk/shell_apk/BUILD.gn
index fb6fabed50357b3b602de6db31d4302a82111f36..7c903c22499824c99e4183f4c8597d660bce3928 100644
--- a/chrome/android/webapk/shell_apk/BUILD.gn
+++ b/chrome/android/webapk/shell_apk/BUILD.gn
@@ -16,6 +16,11 @@ declare_args() {
# The Url of the Web Manifest file.
webapk_web_manifest_url = "https://www.template.com/manifest.json"
+ # Murmur2 hash of the homescreen icon. The hash should be of the icon as it is
+ # available from the web. The icon bytes should not be transformed (e.g.
+ # decoded / encoded) prior to taking the hash.
+ webapk_icon_murmur2_hash = "0L"
+
# Attributes from Web Manifest.
webapk_start_url = "https://www.template.com/home_page"
webapk_name = "Longer Sample WebAPK Name"
@@ -25,14 +30,9 @@ declare_args() {
webapk_orientation = "portrait"
webapk_theme_color = "2147483648L" # HostBrowserLauncher#MANIFEST_COLOR_INVALID_OR_MISSING
webapk_background_color = "2147483648L" #HostBrowserLauncher#MANIFEST_COLOR_INVALID_OR_MISSING
-
- # The URL of the app icon. Empty if the app icon is generated.
- webapk_icon_url = "http://www.template.com/icon.png"
-
- # Murmur2 hash of the homescreen icon. The hash should be of the icon as it is
- # available from the web. The icon bytes should not be transformed (e.g.
- # decoded / encoded) prior to taking the hash.
- webapk_icon_murmur2_hash = "0L"
+ webapk_icon_urls =
+ "http://www.template.com/icon1.png; http://www.template.com/icon2.png"
+ webapk_icon_hashs = "$webapk_icon_murmur2_hash $webapk_icon_murmur2_hash"
pkotwicz 2016/11/11 21:04:19 Nit: webapk_icon_hashs -> webapk_icon_hashes
Xi Han 2016/11/14 19:36:10 Done.
# Host part of |webapk_scope_url|.
webapk_scope_url_host = "www.template.com"
@@ -68,8 +68,8 @@ jinja_template("shell_apk_manifest") {
"orientation=$webapk_orientation",
"theme_color=$webapk_theme_color",
"background_color=$webapk_background_color",
- "icon_url=$webapk_icon_url",
- "icon_murmur2_hash=$webapk_icon_murmur2_hash",
+ "icon_urls=$webapk_icon_urls",
+ "icon_hashs=$webapk_icon_hashs",
"scope_url_host=$webapk_scope_url_host",
"scope_url_path=$webapk_scope_url_path",
"web_manifest_url=$webapk_web_manifest_url",

Powered by Google App Engine
This is Rietveld 408576698