Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: chrome/android/webapk/shell_apk/AndroidManifest.xml

Issue 2453423002: Send all of the icon URLs listed in Web Manifest to WebAPK Server. (Closed)
Patch Set: Remove best_icon_url and best_icon_hash from metadata, but add all icon urls and icon hashs in. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/webapk/shell_apk/AndroidManifest.xml
diff --git a/chrome/android/webapk/shell_apk/AndroidManifest.xml b/chrome/android/webapk/shell_apk/AndroidManifest.xml
index bafd1dc22c4762080fc6f0794c9fc4e77820db74..5de7c68c9770209c2b4859a646989347d59c8917 100644
--- a/chrome/android/webapk/shell_apk/AndroidManifest.xml
+++ b/chrome/android/webapk/shell_apk/AndroidManifest.xml
@@ -48,8 +48,8 @@
<meta-data android:name="org.chromium.webapk.shell_apk.themeColor" android:value="{{ theme_color }}" />
<meta-data android:name="org.chromium.webapk.shell_apk.backgroundColor" android:value="{{ background_color }}" />
<meta-data android:name="org.chromium.webapk.shell_apk.iconId" android:resource="@mipmap/app_icon" />
- <meta-data android:name="org.chromium.webapk.shell_apk.iconUrl" android:value="{{ icon_url }}" />
- <meta-data android:name="org.chromium.webapk.shell_apk.iconMurmur2Hash" android:value="{{ icon_murmur2_hash }}" />
+ <meta-data android:name="org.chromium.webapk.shell_apk.iconUrls" android:value="{{ icon_urls }}" />
+ <meta-data android:name="org.chromium.webapk.shell_apk.iconHashs" android:value="{{ icon_hashs }}" />
pkotwicz 2016/11/11 21:04:19 Make sure that the key matches the constant in Web
Xi Han 2016/11/14 19:36:10 Done.
<meta-data android:name="org.chromium.webapk.shell_apk.webManifestUrl" android:value="{{ web_manifest_url }}" />
<service
android:name="org.chromium.webapk.shell_apk.WebApkServiceFactory"

Powered by Google App Engine
This is Rietveld 408576698