Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: chrome/android/webapk/shell_apk/BUILD.gn

Issue 2453423002: Send all of the icon URLs listed in Web Manifest to WebAPK Server. (Closed)
Patch Set: Remove best_icon_url and best_icon_hash from metadata, but add all icon urls and icon hashs in. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/rules.gni") 5 import("//build/config/android/rules.gni")
6 import("shell_apk_version.gni") 6 import("shell_apk_version.gni")
7 7
8 declare_args() { 8 declare_args() {
9 # The origin URL of the WebAPK. Used to generate a unique package name for 9 # The origin URL of the WebAPK. Used to generate a unique package name for
10 # WebAPK. Example: "foo.com" 10 # WebAPK. Example: "foo.com"
11 webapk_manifest_package_origin = "template" 11 webapk_manifest_package_origin = "template"
12 12
13 # The browser that the WebAPK will be bound to. 13 # The browser that the WebAPK will be bound to.
14 webapk_runtime_host = "com.google.android.apps.chrome" 14 webapk_runtime_host = "com.google.android.apps.chrome"
15 15
16 # The Url of the Web Manifest file. 16 # The Url of the Web Manifest file.
17 webapk_web_manifest_url = "https://www.template.com/manifest.json" 17 webapk_web_manifest_url = "https://www.template.com/manifest.json"
18 18
19 # Murmur2 hash of the homescreen icon. The hash should be of the icon as it is
20 # available from the web. The icon bytes should not be transformed (e.g.
21 # decoded / encoded) prior to taking the hash.
22 webapk_icon_murmur2_hash = "0L"
23
19 # Attributes from Web Manifest. 24 # Attributes from Web Manifest.
20 webapk_start_url = "https://www.template.com/home_page" 25 webapk_start_url = "https://www.template.com/home_page"
21 webapk_name = "Longer Sample WebAPK Name" 26 webapk_name = "Longer Sample WebAPK Name"
22 webapk_short_name = "Sample WebAPK" 27 webapk_short_name = "Sample WebAPK"
23 webapk_scope_url = "https://www.template.com/" 28 webapk_scope_url = "https://www.template.com/"
24 webapk_display_mode = "standalone" 29 webapk_display_mode = "standalone"
25 webapk_orientation = "portrait" 30 webapk_orientation = "portrait"
26 webapk_theme_color = "2147483648L" # HostBrowserLauncher#MANIFEST_COLOR_INVAL ID_OR_MISSING 31 webapk_theme_color = "2147483648L" # HostBrowserLauncher#MANIFEST_COLOR_INVAL ID_OR_MISSING
27 webapk_background_color = "2147483648L" #HostBrowserLauncher#MANIFEST_COLOR_I NVALID_OR_MISSING 32 webapk_background_color = "2147483648L" #HostBrowserLauncher#MANIFEST_COLOR_I NVALID_OR_MISSING
28 33 webapk_icon_urls =
29 # The URL of the app icon. Empty if the app icon is generated. 34 "http://www.template.com/icon1.png; http://www.template.com/icon2.png"
30 webapk_icon_url = "http://www.template.com/icon.png" 35 webapk_icon_hashs = "$webapk_icon_murmur2_hash $webapk_icon_murmur2_hash"
pkotwicz 2016/11/11 21:04:19 Nit: webapk_icon_hashs -> webapk_icon_hashes
Xi Han 2016/11/14 19:36:10 Done.
31
32 # Murmur2 hash of the homescreen icon. The hash should be of the icon as it is
33 # available from the web. The icon bytes should not be transformed (e.g.
34 # decoded / encoded) prior to taking the hash.
35 webapk_icon_murmur2_hash = "0L"
36 36
37 # Host part of |webapk_scope_url|. 37 # Host part of |webapk_scope_url|.
38 webapk_scope_url_host = "www.template.com" 38 webapk_scope_url_host = "www.template.com"
39 39
40 # Path part of |webapk_scope_url|. 40 # Path part of |webapk_scope_url|.
41 webapk_scope_url_path = "/" 41 webapk_scope_url_path = "/"
42 42
43 # Android version code for the WebAPK. 43 # Android version code for the WebAPK.
44 webapk_version_code = "1" 44 webapk_version_code = "1"
45 45
(...skipping 15 matching lines...) Expand all
61 "manifest_package=$shell_apk_manifest_package", 61 "manifest_package=$shell_apk_manifest_package",
62 "runtime_host=$webapk_runtime_host", 62 "runtime_host=$webapk_runtime_host",
63 "start_url=$webapk_start_url", 63 "start_url=$webapk_start_url",
64 "name=$webapk_name", 64 "name=$webapk_name",
65 "short_name=$webapk_short_name", 65 "short_name=$webapk_short_name",
66 "scope_url=$webapk_scope_url", 66 "scope_url=$webapk_scope_url",
67 "display_mode=$webapk_display_mode", 67 "display_mode=$webapk_display_mode",
68 "orientation=$webapk_orientation", 68 "orientation=$webapk_orientation",
69 "theme_color=$webapk_theme_color", 69 "theme_color=$webapk_theme_color",
70 "background_color=$webapk_background_color", 70 "background_color=$webapk_background_color",
71 "icon_url=$webapk_icon_url", 71 "icon_urls=$webapk_icon_urls",
72 "icon_murmur2_hash=$webapk_icon_murmur2_hash", 72 "icon_hashs=$webapk_icon_hashs",
73 "scope_url_host=$webapk_scope_url_host", 73 "scope_url_host=$webapk_scope_url_host",
74 "scope_url_path=$webapk_scope_url_path", 74 "scope_url_path=$webapk_scope_url_path",
75 "web_manifest_url=$webapk_web_manifest_url", 75 "web_manifest_url=$webapk_web_manifest_url",
76 "version_code=$webapk_version_code", 76 "version_code=$webapk_version_code",
77 "version_name=$webapk_version_name", 77 "version_name=$webapk_version_name",
78 ] 78 ]
79 } 79 }
80 80
81 android_resources("shell_apk_resources") { 81 android_resources("shell_apk_resources") {
82 resource_dirs = [ "res" ] 82 resource_dirs = [ "res" ]
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 java_files = [ 140 java_files = [
141 "junit/src/org/chromium/webapk/shell_apk/HostBrowserClassLoaderTest.java", 141 "junit/src/org/chromium/webapk/shell_apk/HostBrowserClassLoaderTest.java",
142 "junit/src/org/chromium/webapk/shell_apk/MainActivityTest.java", 142 "junit/src/org/chromium/webapk/shell_apk/MainActivityTest.java",
143 ] 143 ]
144 deps = [ 144 deps = [
145 ":webapk_java", 145 ":webapk_java",
146 "//chrome/android/webapk/libs/common:common_java", 146 "//chrome/android/webapk/libs/common:common_java",
147 "//chrome/android/webapk/test:junit_test_support", 147 "//chrome/android/webapk/test:junit_test_support",
148 ] 148 ]
149 } 149 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698