chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkMetaDataKeys.java - Issue 2453423002: Send all of the icon URLs listed in Web Manifest to WebAPK Server.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkMetaDataKeys.java

Issue 2453423002: Send all of the icon URLs listed in Web Manifest to WebAPK Server. (Closed)

Patch Set: Remove best_icon_url and best_icon_hash from metadata, but add all icon urls and icon hashs in. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java ('K') | « chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java ('k') | chrome/android/webapk/shell_apk/AndroidManifest.xml » ('j') | chrome/android/webapk/shell_apk/AndroidManifest.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkMetaDataKeys.java

diff --git a/chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkMetaDataKeys.java b/chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkMetaDataKeys.java

index 7e0d3f23b7cc401ac30142e1e8d26a3bcbff16d6..262f8d95e7bbe7efc2bde93e941dc9f86d83f879 100644

--- a/chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkMetaDataKeys.java

+++ b/chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkMetaDataKeys.java

@@ -19,7 +19,8 @@ public final class WebApkMetaDataKeys {

public static final String THEME_COLOR = "org.chromium.webapk.shell_apk.themeColor";

public static final String BACKGROUND_COLOR = "org.chromium.webapk.shell_apk.backgroundColor";

public static final String ICON_ID = "org.chromium.webapk.shell_apk.iconId";

- public static final String ICON_URL = "org.chromium.webapk.shell_apk.iconUrl";

- public static final String ICON_MURMUR2_HASH = "org.chromium.webapk.shell_apk.iconMurmur2Hash";

+ public static final String ICON_URLS = "org.chromium.webapk.shell_apk.iconUrls";

+ public static final String ICON_MURMUR2_HASHS =

pkotwicz 2016/11/11 21:04:19 Nit: HASHES not HASHS

Xi Han 2016/11/14 19:36:10 Done.

+ "org.chromium.webapk.shell_apk.IconMurmur2Hashs";

pkotwicz 2016/11/11 21:04:19 Nit: iconMurmur2Hashes not IconMurmur2Hashs I mad

Xi Han 2016/11/14 19:36:10 Done.

public static final String WEB_MANIFEST_URL = "org.chromium.webapk.shell_apk.webManifestUrl";

}