chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java - Issue 2453423002: Send all of the icon URLs listed in Web Manifest to WebAPK Server.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java

Issue 2453423002: Send all of the icon URLs listed in Web Manifest to WebAPK Server. (Closed)

Patch Set: Remove best_icon_url and best_icon_hash from metadata, but add all icon urls and icon hashs in. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java ('K') | « chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java ('k') | chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkMetaDataKeys.java » ('j') | chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkMetaDataKeys.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java

diff --git a/chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java b/chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java

index 53c2cb7926d8d91528425c43d0ac22f32a2cbdfb..820f78646c59db788ef24e42c7a7a9c174e0492c 100644

--- a/chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java

+++ b/chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java

@@ -20,4 +20,11 @@ public final class WebApkConstants {

public static final String EXTRA_SOURCE = "org.chromium.chrome.browser.webapp_source";

public static final String EXTRA_WEBAPK_PACKAGE_NAME =

"org.chromium.chrome.browser.webapk_package_name";

+ // We use ONE string to store all of the icon URLs in WebAPK's AndroidManifest.xml, and put a

+ // separator between them.

+ public static final String ICON_URL_SEPARATOR = " ";

+ // We use ONE string to store all of the icon hashs in WebAPK's AndroidManifest.xml, and put a

+ // separator between them.

+ public static final String ICON_HASH_SEPARATOR = " ";