Require username and credential for turn/turns

Require username and credential for turn/turns

Gecko also throws for the empty string, but this was discussed and tests
were added, which have already been imported:
https://github.com/w3c/webrtc-pc/issues/885
https://github.com/w3c/web-platform-tests/pull/4071
https://codereview.chromium.org/2468053002

BUG=658423
Committed: https://crrev.com/60abc834aa2183f18029c431c686009685e9d38c
Cr-Commit-Position: refs/heads/master@{#431065}

[foolip, 2016-10-25 13:19:24]

foolip@chromium.org changed reviewers:
+ hta@chromium.org

[foolip, 2016-10-25 13:19:24]

Not ready for review, but if https://github.com/w3c/webrtc-pc/issues/885 is
resolved as I hope this is what it'll look like.

[hta - Chromium, 2016-10-25 13:47:54]

Test coverage nit - let's fix it now.

https://codereview.chromium.org/2451763002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html
(right):

https://codereview.chromium.org/2451763002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html:21:
shouldThrow("new webkitRTCPeerConnection({iceServers:[{urls:['stun:foo.com',
'turn:foo.com']}]});");
This loses test coverage that we succeed if we have two URLs in the urls array.
Can you add a test case for that (with username and credentials, of course)?

[foolip, 2016-11-08 16:02:07]

Description was changed from

==========
Require username and credential for turn/turns

TODO: https://github.com/w3c/webrtc-pc/issues/885

BUG=658423
==========

to

==========
Require username and credential for turn/turns

Gecko also throws for the empty string, but this was discussed and tests
were added to match what this CL does:
https://github.com/w3c/webrtc-pc/issues/885
https://github.com/w3c/web-platform-tests/pull/4071

BUG=658423
==========

[foolip, 2016-11-08 16:03:48]

Description was changed from

==========
Require username and credential for turn/turns

Gecko also throws for the empty string, but this was discussed and tests
were added to match what this CL does:
https://github.com/w3c/webrtc-pc/issues/885
https://github.com/w3c/web-platform-tests/pull/4071

BUG=658423
==========

to

==========
Require username and credential for turn/turns

Gecko also throws for the empty string, but this was discussed and tests
were added, which have already been imported:
https://github.com/w3c/webrtc-pc/issues/885
https://github.com/w3c/web-platform-tests/pull/4071
https://codereview.chromium.org/2468053002

BUG=658423
==========

[foolip, 2016-11-08 16:31:48]

PTAL

https://codereview.chromium.org/2451763002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html
(right):

https://codereview.chromium.org/2451763002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html:21:
shouldThrow("new webkitRTCPeerConnection({iceServers:[{urls:['stun:foo.com',
'turn:foo.com']}]});");
On 2016/10/25 13:47:54, hta - Chromium wrote:
> This loses test coverage that we succeed if we have two URLs in the urls
array.
> Can you add a test case for that (with username and credentials, of course)?

Right you are, I've restored the non-throwing test.

[foolip, 2016-11-08 19:49:47]

The CQ bit was checked by foolip@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 19:50:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 23:12:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 23:12:39]

Dry run: This issue passed the CQ dry run.

[hta - Chromium, 2016-11-09 20:05:48]

lgtm

[foolip, 2016-11-09 20:10:10]

The CQ bit was checked by foolip@chromium.org

[commit-bot: I haz the power, 2016-11-09 20:10:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 22:51:06]

Description was changed from

==========
Require username and credential for turn/turns

Gecko also throws for the empty string, but this was discussed and tests
were added, which have already been imported:
https://github.com/w3c/webrtc-pc/issues/885
https://github.com/w3c/web-platform-tests/pull/4071
https://codereview.chromium.org/2468053002

BUG=658423
==========

to

==========
Require username and credential for turn/turns

Gecko also throws for the empty string, but this was discussed and tests
were added, which have already been imported:
https://github.com/w3c/webrtc-pc/issues/885
https://github.com/w3c/web-platform-tests/pull/4071
https://codereview.chromium.org/2468053002

BUG=658423
==========

[commit-bot: I haz the power, 2016-11-09 22:51:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-09 22:58:30]

Description was changed from

==========
Require username and credential for turn/turns

Gecko also throws for the empty string, but this was discussed and tests
were added, which have already been imported:
https://github.com/w3c/webrtc-pc/issues/885
https://github.com/w3c/web-platform-tests/pull/4071
https://codereview.chromium.org/2468053002

BUG=658423
==========

to

==========
Require username and credential for turn/turns

Gecko also throws for the empty string, but this was discussed and tests
were added, which have already been imported:
https://github.com/w3c/webrtc-pc/issues/885
https://github.com/w3c/web-platform-tests/pull/4071
https://codereview.chromium.org/2468053002

BUG=658423

Committed: https://crrev.com/60abc834aa2183f18029c431c686009685e9d38c
Cr-Commit-Position: refs/heads/master@{#431065}
==========

[commit-bot: I haz the power, 2016-11-09 22:58:31]

Patchset 3 (id:??) landed as
https://crrev.com/60abc834aa2183f18029c431c686009685e9d38c
Cr-Commit-Position: refs/heads/master@{#431065}