third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html - Issue 2451763002: Require username and credential for turn/turns

Side by Side Diff: third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html

Issue 2451763002: Require username and credential for turn/turns (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-expected.txt » ('j') | no next file with comments »

OLD	NEW
1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">	1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../../resources/js-test.js"></script>	4 <script src="../../resources/js-test.js"></script>

5 </head>	5 </head>

6 <body>	6 <body>

7 <script>	7 <script>

8 description("Tests the RTCPeerConnection constructor.");	8 description("Tests the RTCPeerConnection constructor.");

9	9

10 shouldNotThrow("new webkitRTCPeerConnection(null);");	10 shouldNotThrow("new webkitRTCPeerConnection(null);");

11 shouldNotThrow("new webkitRTCPeerConnection(undefined);");	11 shouldNotThrow("new webkitRTCPeerConnection(undefined);");

12 shouldNotThrow("new webkitRTCPeerConnection({});");	12 shouldNotThrow("new webkitRTCPeerConnection({});");

13 shouldNotThrow("new webkitRTCPeerConnection();");	13 shouldNotThrow("new webkitRTCPeerConnection();");

14 shouldThrow("new webkitRTCPeerConnection('');");	14 shouldThrow("new webkitRTCPeerConnection('');");

15	15

16 shouldNotThrow("new webkitRTCPeerConnection({iceServers:[]});");	16 shouldNotThrow("new webkitRTCPeerConnection({iceServers:[]});");

17 shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{url:'stun:foo.com'}]}) ;");	17 shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{url:'stun:foo.com'}]}) ;");

18 shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', cr edential:'x'}]});");	18 shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', us ername:'x', credential:'x'}]});");

19 shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', cr edential:'x'},{url:'stun:bar.com'}]});");	19 shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', us ername:'x', credential:'x'},{url:'stun:bar.com'}]});");

20 shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]} );");	20 shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]} );");

21 shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:['stun:foo.com', 'turn:foo.com']}]});");	21 shouldThrow("new webkitRTCPeerConnection({iceServers:[{urls:['stun:foo.com', 'tu rn:foo.com']}]});");
	hta - Chromium 2016/10/25 13:47:54 This loses test coverage that we succeed if we hav This loses test coverage that we succeed if we have two URLs in the urls array. Can you add a test case for that (with username and credentials, of course)? foolip 2016/11/08 16:31:48 Right you are, I've restored the non-throwing test Show quoted text On 2016/10/25 13:47:54, hta - Chromium wrote: > This loses test coverage that we succeed if we have two URLs in the urls array. > Can you add a test case for that (with username and credentials, of course)? Right you are, I've restored the non-throwing test.
22	22

23 shouldNotThrow("new webkitRTCPeerConnection({fooServers:[]});");	23 shouldNotThrow("new webkitRTCPeerConnection({fooServers:[]});");

24 shouldThrow("new webkitRTCPeerConnection({iceServers:true});");	24 shouldThrow("new webkitRTCPeerConnection({iceServers:true});");

25 shouldThrow("new webkitRTCPeerConnection({iceServers:[1, 2, 3]});");	25 shouldThrow("new webkitRTCPeerConnection({iceServers:[1, 2, 3]});");

26 shouldThrow("new webkitRTCPeerConnection({iceServers:[{}]});");	26 shouldThrow("new webkitRTCPeerConnection({iceServers:[{}]});");

27 shouldThrow("new webkitRTCPeerConnection({iceServers:[{url:'foo'}]});");	27 shouldThrow("new webkitRTCPeerConnection({iceServers:[{url:'foo'}]});");

28 shouldThrow("new webkitRTCPeerConnection({iceServers:[{urls:[1, 'turn:foo.com']} ]});");	28 shouldThrow("new webkitRTCPeerConnection({iceServers:[{urls:[1, 'turn:foo.com']} ]});");

29	29

30 shouldNotThrow("new webkitRTCPeerConnection({iceServers:[], iceTransports:'none' });");	30 shouldNotThrow("new webkitRTCPeerConnection({iceServers:[], iceTransports:'none' });");

31 shouldNotThrow("new webkitRTCPeerConnection({iceServers:[], iceTransports:'relay '});");	31 shouldNotThrow("new webkitRTCPeerConnection({iceServers:[], iceTransports:'relay '});");

(...skipping 80 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
112 }	112 }

113 // Sequentially test construction with RSA and ECDSA certificates.	113 // Sequentially test construction with RSA and ECDSA certificates.

114 // testCertificates3Expired's callback methods mark the end of the async tests.	114 // testCertificates3Expired's callback methods mark the end of the async tests.

115 testCertificates1RSA();	115 testCertificates1RSA();

116	116

117 window.jsTestIsAsync = true;	117 window.jsTestIsAsync = true;

118 window.successfullyParsed = true;	118 window.successfullyParsed = true;

119 </script>	119 </script>

120 </body>	120 </body>

121 </html>	121 </html>

OLD	NEW