Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2468053002: Import wpt@9fcccf38b6be00f71ffa6bd6e29c5aa1ef25ee8c (Closed)

Created:
4 years, 1 month ago by qyearsley
Modified:
4 years, 1 month ago
Reviewers:
tkent, jsbell
CC:
blink-reviews, blink-reviews-style_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, darin-cc_chromium.org, dom-dev_chromium.org, jam, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Import wpt@9fcccf38b6be00f71ffa6bd6e29c5aa1ef25ee8c Using update-w3c-deps in Chromium d1485da7b26285783f75979e1f30a0e30f12f4e9. This is a manually-made update CL, since w3c-test-autoroller has been failing, and I'd like to (1) Get the tests up to date and (2) figure out what else needs to be done to get a successful import. This CL was generated by: 1. Running update-w3c-deps wpt 2. Running webkit-patch rebaseline-cl with a particular set of tests -- due to flaky failures on android, the default behavior of webkit-patch rebaseline-cl downloaded too many bogus baselines for android. This may be the issue that caused 3. Running update-w3c-test-expectations, which added 4 Timeout expectations. Committed: https://crrev.com/9922b3f8941cdf094516575d1741e8a830d9523a Cr-Commit-Position: refs/heads/master@{#429698}

Patch Set 1 #

Patch Set 2 : Rebaseline #

Patch Set 3 : Update TestExpectations #

Patch Set 4 : Add Timeout Pass expectation for Range-mutations-dataChange.html #

Total comments: 6

Patch Set 5 : Skip cssom and svg/shapes, remove unwanted baseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2885 lines, -4544 lines) Patch
M third_party/WebKit/LayoutTests/NeverFixTests View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/SlowTests View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/W3CImportExpectations View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/budget/interfaces-expected.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-fetch-expected.txt View 1 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/fetch/serviceworker/request-base-https-other-https-expected.txt View 1 1 chunk +42 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/fetch/serviceworker/request-expected.txt View 1 1 chunk +42 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/fetch/window/request-base-https-other-https-expected.txt View 1 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/fetch/window/request-expected.txt View 1 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/fetch/workers/request-base-https-other-https-expected.txt View 1 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/fetch/workers/request-expected.txt View 1 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-fetch-resources-expected.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/streams/readable-streams/count-queuing-strategy-integration-expected.txt View 1 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/MANIFEST.json View 33 chunks +327 lines, -30 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/check_stability.py View 7 chunks +70 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/ci_stability.sh View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/custom-elements/htmlconstructor/newtarget.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/custom-elements/htmlconstructor/newtarget-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/CSSStyleDeclaration.html View 1 chunk +85 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/CSSStyleDeclaration-expected.txt View 1 1 chunk +39 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/Document.html View 1 chunk +65 lines, -21 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/resources/reactions.js View 1 chunk +99 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/custom-elements/resources/custom-elements-helpers.js View 1 chunk +59 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/dom/events/Event-dispatch-click.html View 2 chunks +87 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/DOMImplementation-createDocument.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/DOMImplementation-createDocument-expected.txt View 1 5 chunks +168 lines, -168 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/dom/ranges/Range-mutations.html View 1 chunk +0 lines, -950 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/dom/ranges/Range-mutations.js View 2 chunks +0 lines, -29 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/dom/ranges/Range-mutations-appendChild.html View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/dom/ranges/Range-mutations-appendChild-expected.txt View 1 1 chunk +85 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/dom/ranges/Range-mutations-appendData.html View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/dom/ranges/Range-mutations-dataChange.html View 1 chunk +14 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/dom/ranges/Range-mutations-dataChange-expected.txt View 1 2 chunks +216 lines, -3259 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/dom/ranges/Range-mutations-deleteData.html View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/dom/ranges/Range-mutations-insertBefore.html View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/dom/ranges/Range-mutations-insertBefore-expected.txt View 1 1 chunk +91 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/dom/ranges/Range-mutations-insertData.html View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/dom/ranges/Range-mutations-removeChild.html View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/dom/ranges/Range-mutations-replaceChild.html View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/dom/ranges/Range-mutations-replaceChild-expected.txt View 1 1 chunk +75 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/dom/ranges/Range-mutations-replaceData.html View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/dom/ranges/Range-mutations-splitText.html View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/dom/ranges/Range-mutations-splitText-expected.txt View 1 1 chunk +126 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/hr-time/idlharness.html View 1 chunk +17 lines, -6 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/hr-time/idlharness-expected.txt View 1 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/browsers/sandboxing/sandbox-allow-same-origin.html View 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/browsers/sandboxing/sandbox-allow-scripts.html View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/browsers/sandboxing/sandbox-disallow-same-origin.html View 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/browsers/sandboxing/sandbox-disallow-scripts.html View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/infrastructure/common-dom-interfaces/collections/historical.html View 1 chunk +25 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/html/semantics/document-metadata/the-link-element/all View 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/semantics/document-metadata/the-link-element/all.headers View 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/html/semantics/document-metadata/the-link-element/resources/empty-href.css View 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/semantics/document-metadata/the-link-element/stylesheet-empty-href.html View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/semantics/document-metadata/the-link-element/stylesheet-empty-href-expected.html View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/semantics/document-metadata/the-link-element/stylesheet-media.html View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/semantics/document-metadata/the-link-element/stylesheet-media-expected.html View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/the-embed-element/historical.html View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/the-embed-element/historical-expected.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/the-img-element/usemap-casing.html View 1 chunk +93 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/the-img-element/usemap-casing-expected.txt View 1 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/the-object-element/historical.html View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/the-object-element/historical-expected.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/the-object-element/usemap-casing.html View 1 chunk +93 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/the-object-element/usemap-casing-expected.txt View 1 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/resetting-a-form/reset-form.html View 2 chunks +17 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/the-form-element/form-action-url.html View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/the-form-element/resources/form-action-url-iframe.html View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/the-input-element/radio-groupname-case.html View 2 chunks +33 lines, -25 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/the-input-element/radio-groupname-case-expected.txt View 1 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/the-select-element/common-HTMLOptionsCollection.html View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/the-select-element/common-HTMLOptionsCollection-add.html View 1 chunk +89 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/the-select-element/selected-index.html View 1 chunk +73 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/semantics/scripting-1/the-template-element/template-element/node-document-changes.html View 7 chunks +0 lines, -7 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/webappapis/scripting/events/uncompiled_event_handler_with_scripting_disabled.html View 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/resources/testharness.js View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/webrtc/rtcpeerconnection/rtcpeerconnection-constructor.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/webrtc/simplecall.html View 2 chunks +8 lines, -7 lines 0 comments Download
A third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-unique-origin-expected.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/nfc/push-expected.txt View 1 1 chunk +42 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/resources/testharness.js View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 21 (15 generated)
qyearsley
4 years, 1 month ago (2016-11-02 22:09:24 UTC) #7
tkent
lgtm As for non-WPT failures, we should file a bug and notice the failure to ...
4 years, 1 month ago (2016-11-03 13:40:52 UTC) #10
qyearsley
Thanks for review Kent -- now skipped cssom and svg/shapes and removed the baseline for ...
4 years, 1 month ago (2016-11-03 21:18:10 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468053002/80001
4 years, 1 month ago (2016-11-03 21:19:08 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-11-03 21:28:43 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 21:32:41 UTC) #21
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/9922b3f8941cdf094516575d1741e8a830d9523a
Cr-Commit-Position: refs/heads/master@{#429698}

Powered by Google App Engine
This is Rietveld 408576698