Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2451743002: [ObjC ARC] Converts the rest of ios/web to ARC. (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts the rest of ios/web to ARC. Notable changes: * added some bridge casts instead of reinterpret_casts BUG=624365 TEST=None

Patch Set 1 #

Patch Set 2 : rebzse #

Patch Set 3 : schrebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -56 lines) Patch
M ios/web/BUILD.gn View 1 2 3 chunks +16 lines, -50 lines 0 comments Download
M ios/web/web_state/web_state.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/web_state/web_state_delegate.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/web_state/web_state_delegate_bridge.mm View 2 chunks +5 lines, -1 line 0 comments Download
M ios/web/web_state/web_state_impl.mm View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M ios/web/web_state/web_state_observer.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/web_state/web_state_observer_bridge.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/web_state/web_state_policy_decider.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/web_state/web_state_weak_ptr_factory.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/web_state/web_view_internal_creation_util.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/web_state/wk_web_view_security_util.mm View 3 chunks +8 lines, -4 lines 0 comments Download

Depends on Patchset:

Issue 2432363003 Patch 100001

Dependent Patchsets:

Issue 2454773002 Patch 40001

Messages

Total messages: 8 (8 generated)
stkhapugin
The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-10-25 13:08:09 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451743002/1
4 years, 1 month ago (2016-10-25 13:08:28 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-10-25 13:10:51 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/93758)
4 years, 1 month ago (2016-10-25 13:10:52 UTC) #4
stkhapugin
The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-10-26 16:35:33 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451743002/20001
4 years, 1 month ago (2016-10-26 16:35:59 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-10-26 17:02:59 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 17:03:00 UTC) #8 
Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

Powered by Google App Engine
This is Rietveld 408576698