Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2432363003: [ObjC ARC] Converts parts of ios/web/webstate to ARC. (Closed)

Created:
4 years, 2 months ago by stkhapugin
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts parts of ios/web/webstate to ARC. Notable changes: * removed a [[foo retain] autorelease] in one place, where the object will be retain-autoreleased by ARC when it is acquired by calling a method that returns it. BUG=624365 TEST=None

Patch Set 1 #

Patch Set 2 : autoreleasepool #

Patch Set 3 : rebase fail #

Patch Set 4 : s/scoped_nsobject/strong ivar #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -65 lines) Patch
M ios/web/BUILD.gn View 1 2 3 4 5 2 chunks +13 lines, -13 lines 0 comments Download
M ios/web/public/web_state/ui/crw_web_view_content_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/ui/crw_web_controller_container_view.h View 1 chunk +4 lines, -5 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller_container_view.mm View 1 2 11 chunks +20 lines, -25 lines 0 comments Download
M ios/web/web_state/ui/crw_web_view_content_view.mm View 2 chunks +6 lines, -2 lines 0 comments Download
M ios/web/web_state/ui/crw_wk_script_message_router.h View 1 chunk +2 lines, -1 line 0 comments Download
M ios/web/web_state/ui/crw_wk_script_message_router.mm View 3 chunks +5 lines, -4 lines 0 comments Download
M ios/web/web_state/ui/web_view_js_utils.mm View 2 chunks +5 lines, -1 line 0 comments Download
M ios/web/web_state/ui/wk_back_forward_list_item_holder.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/wk_web_view_configuration_provider.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/web_state/ui/wk_web_view_configuration_provider.mm View 1 2 3 4 5 6 chunks +17 lines, -11 lines 0 comments Download
M ios/web/web_state/web_controller_observer_bridge.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2434853002 Patch 120001

Dependent Patchsets:

Issue 2451743002 Patch 60001

Messages

Total messages: 12 (12 generated)
stkhapugin
The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-19 17:02:29 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2432363003/1
4 years, 2 months ago (2016-10-19 17:03:23 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-19 17:29:08 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/90773)
4 years, 2 months ago (2016-10-19 17:29:09 UTC) #4
stkhapugin
The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-20 16:21:23 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2432363003/40001
4 years, 2 months ago (2016-10-20 16:21:41 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-20 17:53:24 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 2 months ago (2016-10-20 17:53:25 UTC) #8
stkhapugin
The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-10-24 11:45:43 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2432363003/60001
4 years, 1 month ago (2016-10-24 11:45:59 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-10-24 13:37:41 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 13:37:42 UTC) #12 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698