Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelection.h

Issue 2451613003: Get rid of createVisibleSelection() taking two Position (Closed)
Patch Set: 2016-10-26T15:09:55 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleSelection.h
diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.h b/third_party/WebKit/Source/core/editing/VisibleSelection.h
index 1e01900bf0ed0f9a1201f83ba78613bc693db971..55b88264368ff0b13af9705a50e7a2698c063400 100644
--- a/third_party/WebKit/Source/core/editing/VisibleSelection.h
+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.h
@@ -206,15 +206,7 @@ using VisibleSelection = VisibleSelectionTemplate<EditingStrategy>;
using VisibleSelectionInFlatTree =
VisibleSelectionTemplate<EditingInFlatTreeStrategy>;
-// TODO(yosin): We should get rid of |createVisibleSelection()| overloads
-// except for taking |SelectionInDOMTree| and |SelectionInFlatTree|.
CORE_EXPORT VisibleSelection createVisibleSelection(const SelectionInDOMTree&);
-CORE_EXPORT VisibleSelection
-createVisibleSelection(const Position& base,
- const Position& extent,
- TextAffinity = SelDefaultAffinity,
- bool isDirectional = false);
-
CORE_EXPORT VisibleSelectionInFlatTree
createVisibleSelection(const SelectionInFlatTree&);

Powered by Google App Engine
This is Rietveld 408576698