Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2451423002: [MD Settings][People] Fixes the 'arrow icon' appearing momentarily on page refresh. (Closed)

Created:
4 years, 1 month ago by Moe
Modified:
4 years, 1 month ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Settings][People] Fixes the 'arrow icon' appearing momentarily on page refresh. BUG=657338 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/177bf7169b7de6de71d449a4592fe7032b6dd260 Cr-Commit-Position: refs/heads/master@{#428153}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -29 lines) Patch
M chrome/browser/resources/settings/people_page/people_page.html View 1 chunk +31 lines, -28 lines 0 comments Download
M chrome/browser/resources/settings/people_page/people_page.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/webui/settings/people_page_test.js View 3 chunks +7 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 25 (19 generated)
Moe
Hi Tommy, Please review this CL. It seems like while syncStatus is undefined, the bindings ...
4 years, 1 month ago (2016-10-27 03:54:57 UTC) #5
tommycli
lgtm seems like an improvement, even if it's not perfect... Since the sync status is ...
4 years, 1 month ago (2016-10-27 21:10:36 UTC) #17
Moe
On 2016/10/27 21:10:36, tommycli wrote: > lgtm seems like an improvement, even if it's not ...
4 years, 1 month ago (2016-10-27 21:59:34 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451423002/20001
4 years, 1 month ago (2016-10-27 22:00:07 UTC) #22
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 1 month ago (2016-10-27 22:08:14 UTC) #23
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 22:11:13 UTC) #25
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/177bf7169b7de6de71d449a4592fe7032b6dd260
Cr-Commit-Position: refs/heads/master@{#428153}

Powered by Google App Engine
This is Rietveld 408576698