Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2720)

Unified Diff: chrome/browser/resources/settings/people_page/people_page.html

Issue 2451423002: [MD Settings][People] Fixes the 'arrow icon' appearing momentarily on page refresh. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/people_page/people_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/people_page/people_page.html
diff --git a/chrome/browser/resources/settings/people_page/people_page.html b/chrome/browser/resources/settings/people_page/people_page.html
index 0e2990632b1e762aafbf2a4cd4adc207b97518ea..d7de0608bb4bb497be6e3c1c7b77360a6d47a219 100644
--- a/chrome/browser/resources/settings/people_page/people_page.html
+++ b/chrome/browser/resources/settings/people_page/people_page.html
@@ -84,42 +84,45 @@
<settings-animated-pages id="pages" section="people">
<neon-animatable route-path="default">
<div id="picture-subpage-trigger" class="settings-box first two-line">
- <div id="profile-icon" on-tap="onPictureTap_" actionable
- style="background-image: [[getIconImageset_(profileIconUrl_)]]">
- </div>
+ <template is="dom-if" if="[[syncStatus]]">
+ <div id="profile-icon" on-tap="onPictureTap_" actionable
+ style="background-image: [[getIconImageset_(profileIconUrl_)]]">
+ </div>
<if expr="not chromeos">
- <div class="middle two-line" on-tap="onProfileNameTap_" actionable>
+ <div class="middle two-line" on-tap="onProfileNameTap_" actionable>
</if>
<if expr="chromeos">
- <div class="middle two-line" on-tap="onPictureTap_" actionable>
+ <div class="middle two-line" on-tap="onPictureTap_" actionable>
</if>
- <div class="flex">
- <span id="profile-name">[[profileName_]]</span>
- <div class="secondary" hidden="[[!syncStatus.signedIn]]">
- [[syncStatus.signedInUsername]]
+ <div class="flex">
+ <span id="profile-name">[[profileName_]]</span>
+ <div class="secondary" hidden="[[!syncStatus.signedIn]]">
+ [[syncStatus.signedInUsername]]
+ </div>
</div>
+ <button class="subpage-arrow" is="paper-icon-button-light">
+ </button>
</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
- </div>
<if expr="not chromeos">
- <template is="dom-if" if="[[showSignin_(syncStatus)]]">
- <span class="secondary-action">
- <paper-button class="primary-button" on-tap="onSigninTap_"
- disabled="[[syncStatus.setupInProgress]]">
- $i18n{syncSignin}
- </paper-button>
- </span>
- </template>
- <template is="dom-if" if="[[syncStatus.signedIn]]">
- <span class="secondary-action">
- <paper-button id="disconnectButton" class="secondary-button"
- on-tap="onDisconnectTap_"
- disabled="[[syncStatus.setupInProgress]]">
- $i18n{syncDisconnect}
- </paper-button>
- </span>
- </template>
+ <template is="dom-if" if="[[showSignin_(syncStatus)]]">
+ <span class="secondary-action">
+ <paper-button class="primary-button" on-tap="onSigninTap_"
+ disabled="[[syncStatus.setupInProgress]]">
+ $i18n{syncSignin}
+ </paper-button>
+ </span>
+ </template>
+ <template is="dom-if" if="[[syncStatus.signedIn]]">
+ <span class="secondary-action">
+ <paper-button id="disconnectButton" class="secondary-button"
+ on-tap="onDisconnectTap_"
+ disabled="[[syncStatus.setupInProgress]]">
+ $i18n{syncDisconnect}
+ </paper-button>
+ </span>
+ </template>
</if>
+ </template>
</div>
<div class="settings-box two-line"
hidden="[[!showSignin_(syncStatus)]]">
« no previous file with comments | « no previous file | chrome/browser/resources/settings/people_page/people_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698