Add presubmit explaining embedding translations in shared UI code

Add presubmit explaining embedding translations in shared UI code

R=jdufault@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/14fff6b7c66dfb2deb347d140c58b0fd5aa67536
Cr-Commit-Position: refs/heads/master@{#428272}

[Dan Beam, 2016-10-27 23:23:41]

Description was changed from

==========
Add presubmit explaining embedding translations in shared UI code

R=jdufault@chromium.org
BUG=none
==========

to

==========
Add presubmit explaining embedding translations in shared UI code

R=jdufault@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-10-27 23:26:12]

wdyt?

[Dan Beam, 2016-10-27 23:26:18]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 23:27:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdufault, 2016-10-27 23:33:59]

On 2016/10/27 23:26:12, Dan Beam wrote:
> wdyt?

Seams reasonable. $i18n{...} in the ui/webui html files does not get processed
though, which is why all of the code uses I18nBehavior / loadTimeData.

[commit-bot: I haz the power, 2016-10-27 23:36:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 23:36:38]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2016-10-27 23:41:34]

On 2016/10/27 23:33:59, jdufault wrote:
> On 2016/10/27 23:26:12, Dan Beam wrote:
> > wdyt?
> 
> Seams reasonable. $i18n{...} in the ui/webui html files does not get processed
> though, which is why all of the code uses I18nBehavior / loadTimeData.

yeah, i know, but there's no alarms that go off either (in chrome/ if you use
$i18n{keyThatDoesntExist} we crash the browser, but if somebody writes $i18n{}
in this code assuming it'll work and doesn't check it... you end up with the
literal "$i18n{...}" content left in the page)

[stevenjb, 2016-10-28 00:28:26]

stevenjb@chromium.org changed reviewers:
+ stevenjb@chromium.org

[stevenjb, 2016-10-28 00:28:26]

lgtm, thanks for adding this!

[Dan Beam, 2016-10-28 03:33:43]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-10-28 03:34:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 03:38:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-28 03:42:27]

Description was changed from

==========
Add presubmit explaining embedding translations in shared UI code

R=jdufault@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add presubmit explaining embedding translations in shared UI code

R=jdufault@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/14fff6b7c66dfb2deb347d140c58b0fd5aa67536
Cr-Commit-Position: refs/heads/master@{#428272}
==========

[commit-bot: I haz the power, 2016-10-28 03:42:28]

Patchset 2 (id:??) landed as
https://crrev.com/14fff6b7c66dfb2deb347d140c58b0fd5aa67536
Cr-Commit-Position: refs/heads/master@{#428272}