[modules] Improve error messages.

[modules] Improve error messages.

For instance, when an import cannot be resolved, actually
point at the corresponding import statement.

BUG=v8:1569
Committed: https://crrev.com/038a81976efdfa399da1b872a349d344d1aba837
Cr-Commit-Position: refs/heads/master@{#40594}

[neis, 2016-10-26 12:04:01]

Description was changed from

==========
Merge branch 'master' of https://chromium.googlesource.com/v8/v8 into
modules-errors


gsave


gsave


gsave


gaga


gsave


gsave


gsave


gsave


gsave

BUG=
==========

to

==========
[modules] Improve error messages.

For instance, when an import cannot be resolved, actually point at the
corresponding import statement.

BUG=v8:1569
==========

[neis, 2016-10-26 12:04:01]

neis@chromium.org changed reviewers:
+ adamk@chromium.org

[neis, 2016-10-26 12:10:36]

Patchset #1 (id:1) has been deleted

[neis, 2016-10-26 12:10:47]

Patchset #1 (id:20001) has been deleted

[neis, 2016-10-26 12:11:02]

Patchset #1 (id:40001) has been deleted

[neis, 2016-10-26 12:11:19]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[neis, 2016-10-26 12:11:26]

Description was changed from

==========
[modules] Improve error messages.

For instance, when an import cannot be resolved, actually point at the
corresponding import statement.

BUG=v8:1569
==========

to

==========
[modules] Improve error messages.

For instance, when an import cannot be resolved, actually
point at the corresponding import statement.

BUG=v8:1569
==========

[commit-bot: I haz the power, 2016-10-26 12:11:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[neis, 2016-10-26 12:11:41]

ptal

[commit-bot: I haz the power, 2016-10-26 12:14:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 12:14:57]

Dry run: Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/27333)

[adamk, 2016-10-26 12:38:16]

lgtm!

https://codereview.chromium.org/2451153002/diff/60001/src/ast/modules.cc
File src/ast/modules.cc (right):

https://codereview.chromium.org/2451153002/diff/60001/src/ast/modules.cc#newc...
src/ast/modules.cc:194: entry->location.beg_pos =
import->second->location.beg_pos;
Why can't you just assign the location directly?

https://codereview.chromium.org/2451153002/diff/60001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2451153002/diff/60001/src/objects.cc#newcode1...
src/objects.cc:19955: int beg_pos = entry->beg_pos();
These can be inlined into the constructor call two lines down (same for other
cases below)

[neis, 2016-10-26 14:40:01]

The CQ bit was checked by neis@chromium.org

[neis, 2016-10-26 14:40:02]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/2451153002/#ps2 (title:
"Address comments.")

[commit-bot: I haz the power, 2016-10-26 14:40:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 15:09:54]

Description was changed from

==========
[modules] Improve error messages.

For instance, when an import cannot be resolved, actually
point at the corresponding import statement.

BUG=v8:1569
==========

to

==========
[modules] Improve error messages.

For instance, when an import cannot be resolved, actually
point at the corresponding import statement.

BUG=v8:1569
==========

[commit-bot: I haz the power, 2016-10-26 15:09:55]

Committed patchset #2 (id:2)

[commit-bot: I haz the power, 2016-11-17 22:14:09]

Description was changed from

==========
[modules] Improve error messages.

For instance, when an import cannot be resolved, actually
point at the corresponding import statement.

BUG=v8:1569
==========

to

==========
[modules] Improve error messages.

For instance, when an import cannot be resolved, actually
point at the corresponding import statement.

BUG=v8:1569

Committed: https://crrev.com/038a81976efdfa399da1b872a349d344d1aba837
Cr-Commit-Position: refs/heads/master@{#40594}
==========

[commit-bot: I haz the power, 2016-11-17 22:14:10]

Patchset 2 (id:??) landed as
https://crrev.com/038a81976efdfa399da1b872a349d344d1aba837
Cr-Commit-Position: refs/heads/master@{#40594}