Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: src/objects-inl.h

Issue 2451153002: [modules] Improve error messages. (Closed)
Patch Set: Address comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.cc ('k') | src/parsing/parser.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 8030 matching lines...) Expand 10 before | Expand all | Expand 10 after
8041 Object* ModuleInfoEntry::export_name() const { return get(kExportNameIndex); } 8041 Object* ModuleInfoEntry::export_name() const { return get(kExportNameIndex); }
8042 8042
8043 Object* ModuleInfoEntry::local_name() const { return get(kLocalNameIndex); } 8043 Object* ModuleInfoEntry::local_name() const { return get(kLocalNameIndex); }
8044 8044
8045 Object* ModuleInfoEntry::import_name() const { return get(kImportNameIndex); } 8045 Object* ModuleInfoEntry::import_name() const { return get(kImportNameIndex); }
8046 8046
8047 Object* ModuleInfoEntry::module_request() const { 8047 Object* ModuleInfoEntry::module_request() const {
8048 return get(kModuleRequestIndex); 8048 return get(kModuleRequestIndex);
8049 } 8049 }
8050 8050
8051 int ModuleInfoEntry::beg_pos() const {
8052 return Smi::cast(get(kBegPosIndex))->value();
8053 }
8054
8055 int ModuleInfoEntry::end_pos() const {
8056 return Smi::cast(get(kEndPosIndex))->value();
8057 }
8058
8051 FixedArray* ModuleInfo::module_requests() const { 8059 FixedArray* ModuleInfo::module_requests() const {
8052 return FixedArray::cast(get(kModuleRequestsIndex)); 8060 return FixedArray::cast(get(kModuleRequestsIndex));
8053 } 8061 }
8054 8062
8055 FixedArray* ModuleInfo::special_exports() const { 8063 FixedArray* ModuleInfo::special_exports() const {
8056 return FixedArray::cast(get(kSpecialExportsIndex)); 8064 return FixedArray::cast(get(kSpecialExportsIndex));
8057 } 8065 }
8058 8066
8059 FixedArray* ModuleInfo::regular_exports() const { 8067 FixedArray* ModuleInfo::regular_exports() const {
8060 return FixedArray::cast(get(kRegularExportsIndex)); 8068 return FixedArray::cast(get(kRegularExportsIndex));
(...skipping 354 matching lines...) Expand 10 before | Expand all | Expand 10 after
8415 #undef WRITE_INT64_FIELD 8423 #undef WRITE_INT64_FIELD
8416 #undef READ_BYTE_FIELD 8424 #undef READ_BYTE_FIELD
8417 #undef WRITE_BYTE_FIELD 8425 #undef WRITE_BYTE_FIELD
8418 #undef NOBARRIER_READ_BYTE_FIELD 8426 #undef NOBARRIER_READ_BYTE_FIELD
8419 #undef NOBARRIER_WRITE_BYTE_FIELD 8427 #undef NOBARRIER_WRITE_BYTE_FIELD
8420 8428
8421 } // namespace internal 8429 } // namespace internal
8422 } // namespace v8 8430 } // namespace v8
8423 8431
8424 #endif // V8_OBJECTS_INL_H_ 8432 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | src/parsing/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698