Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: test/mjsunit/mjsunit.status

Issue 2451153002: [modules] Improve error messages. (Closed)
Patch Set: Address comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/message/modules-undefined-export2.out ('k') | test/mjsunit/modules-fail-1.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/mjsunit.status
diff --git a/test/mjsunit/mjsunit.status b/test/mjsunit/mjsunit.status
index da83f4489f99e478299abfe5207df75f72424c46..b16ef6fea9d267b4b8b1aae8ac51657919e3ca59 100644
--- a/test/mjsunit/mjsunit.status
+++ b/test/mjsunit/mjsunit.status
@@ -27,6 +27,10 @@
[
[ALWAYS, {
+ # Modules which are only meant to be imported from by other tests, not to be
+ # tested standalone.
+ 'modules-skip*': [SKIP],
+
# All tests in the bug directory are expected to fail.
'bugs/*': [FAIL],
@@ -751,17 +755,6 @@
}], # variant == ignition_turbofan and msan
##############################################################################
-['variant == ignition or variant == ignition_staging or variant == ignition_turbofan', {
- # Modules for which execution must fail (e.g. because of unresolved imports).
- # Eventually we should test for the precise error message, but for now we only
- # ensure that there is an error.
- 'modules-fail*': [FAIL],
-
- # Modules which are only meant to be imported from by other tests, not to be
- # tested standalone.
- 'modules-skip*': [SKIP],
-}], # variant == ignition or variant == ignition_staging or variant == ignition_turbofan
-
['variant != ignition and variant != ignition_staging and variant != ignition_turbofan', {
# Ongoing implementation of modules.
# https://bugs.chromium.org/p/v8/issues/detail?id=1569
« no previous file with comments | « test/message/modules-undefined-export2.out ('k') | test/mjsunit/modules-fail-1.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698