Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2449)

Unified Diff: chrome/browser/resources/md_history/app.js

Issue 2450663003: MD History: hide tooltip promo when drawer is swiped open (Closed)
Patch Set: tweaks Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_history/app.js
diff --git a/chrome/browser/resources/md_history/app.js b/chrome/browser/resources/md_history/app.js
index 730ff7e0f8df5ed2bc22725f490c70eadd30e955..f9ea7a018821ef41e4c73f518ac2ea325e4f0aa8 100644
--- a/chrome/browser/resources/md_history/app.js
+++ b/chrome/browser/resources/md_history/app.js
@@ -86,7 +86,15 @@ Polymer({
type: Boolean,
reflectToAttribute: true,
notify: true,
- }
+ },
+
+ showMenuPromo_: {
+ type: Boolean,
+ value: function() {
+ return loadTimeData.getBoolean('showMenuPromo');
+ },
+ observer: 'showMenuPromoChanged_',
+ },
},
// TODO(calamity): Replace these event listeners with data bound properties.
@@ -147,6 +155,30 @@ Polymer({
},
/**
+ * @param {!CustomEvent} e
+ * @private
+ */
+ onOpenedChanged_: function(e) {
+ if (e.detail.value)
+ this.showMenuPromo_ = false;
+ },
+
+ /** @private */
+ onCrToolbarPromoClose_: function() {
+ this.showMenuPromo_ = false;
+ },
+
+ /**
+ * @param {boolean} showMenuPromo
+ * @param {boolean|undefined} oldShowMenuPromo
+ * @private
+ */
+ showMenuPromoChanged_: function(showMenuPromo, oldShowMenuPromo) {
+ if (!showMenuPromo && oldShowMenuPromo)
Dan Beam 2016/10/27 03:22:18 damn it, this code wasn't even necessary after all
+ md_history.BrowserService.getInstance().menuPromoShown();
+ },
+
+ /**
* Listens for history-item being selected or deselected (through checkbox)
* and changes the view of the top toolbar.
* @param {{detail: {countAddition: number}}} e

Powered by Google App Engine
This is Rietveld 408576698