ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.js - Issue 2450663003: MD History: hide tooltip promo when drawer is swiped open

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.js

Issue 2450663003: MD History: hide tooltip promo when drawer is swiped open (Closed)

Patch Set: tweaks Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.js

diff --git a/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.js b/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.js

index d69e634e6efad675b2df266494ae744f1951f205..198d08c3f6bde16f07be47edc8d8d184786b542e 100644

--- a/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.js

+++ b/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.js

@@ -64,13 +64,12 @@ Polymer({

/** @private */

onClosePromoTap_: function() {

- this.showMenuPromo = false;

+ this.fire('cr-toolbar-promo-close');

/** @private */

onMenuTap_: function() {

this.fire('cr-menu-tap');

calamity 2016/10/27 03:20:31 nit: This is a very confusing event name, especial

Dan Beam 2016/10/27 03:42:18 Done.

- this.onClosePromoTap_();

/** @private */