Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1620)

Unified Diff: chrome/browser/resources/md_history/app.html

Issue 2450663003: MD History: hide tooltip promo when drawer is swiped open (Closed)
Patch Set: tweaks Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_history/app.html
diff --git a/chrome/browser/resources/md_history/app.html b/chrome/browser/resources/md_history/app.html
index f6a3538678cc677c61dce4972f8487d674ebad8c..2d9482ed15724b7330e69ae0457ade324814e618 100644
--- a/chrome/browser/resources/md_history/app.html
+++ b/chrome/browser/resources/md_history/app.html
@@ -21,10 +21,12 @@
display: block;
height: 100%;
overflow: hidden;
+ z-index: 0;
}
history-toolbar {
background: var(--md-toolbar-color);
+ z-index: 2;
}
/* Sizing this with flex causes slow load performance, see
@@ -32,6 +34,7 @@
#main-container {
height: calc(100% - var(--toolbar-height));
position: relative;
+ z-index: 1;
}
:host([grouped_]) #main-container {
@@ -55,6 +58,10 @@
display: none;
}
+ #drawer {
+ z-index: 3;
+ }
+
#drawer-header {
align-items: center;
border-bottom: 1px solid rgba(0, 0, 0, 0.08);
@@ -99,7 +106,9 @@
query-start-time="[[queryResult_.info.queryStartTime]]"
query-end-time="[[queryResult_.info.queryEndTime]]"
has-drawer="[[hasDrawer_]]"
- show-sync-notice="[[showSyncNotice_(hasSyncedResults, selectedPage_)]]">
+ show-sync-notice="[[showSyncNotice_(hasSyncedResults, selectedPage_)]]"
+ show-menu-promo="[[showMenuPromo_]]"
+ on-cr-toolbar-promo-close="onCrToolbarPromoClose_">
calamity 2016/10/27 03:20:31 nit: The rest of the event listeners are in the js
Dan Beam 2016/10/27 03:42:18 Done.
</history-toolbar>
<div id="main-container">
@@ -128,7 +137,8 @@
</div>
<template is="dom-if" if="[[hasDrawer_]]">
- <app-drawer id="drawer" swipe-open align="start" tabindex="0">
+ <app-drawer id="drawer" swipe-open align="start" tabindex="0"
+ on-opened-changed="onOpenedChanged_">
<div id="drawer-header">
<h1>$i18n{title}</h1>
</div>

Powered by Google App Engine
This is Rietveld 408576698