Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2450603005: [Devtools] Moved NetworkTimelineColumn to NetworkLogViewColumns P2 (Closed)

Created:
4 years, 1 month ago by allada
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Moved NetworkTimelineColumn to NetworkLogViewColumns P2 This patch removes all traces of timeline from NetworkLogView and moves the dependency into NetworkLogViewColumns. This is part 2. Part 1 is: https://codereview.chromium.org/2443683002/ R=dgozman BUG=653738 Committed: https://crrev.com/611da05ec3bd65457637663321051109217a3bb1 Cr-Commit-Position: refs/heads/master@{#428063}

Patch Set 1 : changes #

Patch Set 2 : Merge branch 'NETWORK_TIMELINE_12_RESTRUCTURE_NETWORK_LOG_VIEW' into NETWORK_TIMELINE_14_RESTRUCTUR… #

Patch Set 3 : changes #

Patch Set 4 : [Devtools] Moved NetworkTimelineColumn to NetworkLogViewColumns P2 #

Messages

Total messages: 23 (18 generated)
allada
PTL
4 years, 1 month ago (2016-10-26 00:50:16 UTC) #3
dgozman
lgtm
4 years, 1 month ago (2016-10-26 01:39:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450603005/80001
4 years, 1 month ago (2016-10-27 17:05:56 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 1 month ago (2016-10-27 17:11:39 UTC) #21
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 17:31:10 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/611da05ec3bd65457637663321051109217a3bb1
Cr-Commit-Position: refs/heads/master@{#428063}

Powered by Google App Engine
This is Rietveld 408576698