|
|
Created:
4 years, 2 months ago by allada Modified:
4 years, 1 month ago Reviewers:
dgozman CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Devtools] Move NetworkTimelineColumn into NetworkLogViewColumns P1
This patch is restructuring NetworkLogView and NetworkLogViewColumns
in preporation of moving all code relating to NetworkTimelineColumn
into NetworkLogViewColumns.
This is Part 1.
R=dgozman
BUG=653738
Committed: https://crrev.com/ab0c2f3cca120934b625f2ff7e8cc79ea4cf58cf
Cr-Commit-Position: refs/heads/master@{#428051}
Patch Set 1 : changes #Patch Set 2 : Merge branch 'CLEANUP_DATAGRID_2' into NETWORK_TIMELINE_12_RESTRUCTURE_NETWORK_LOG_VIEW #Patch Set 3 : changes #
Dependent Patchsets: Messages
Total messages: 33 (22 generated)
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
PTL
Patchset #1 (id:40001) has been deleted
Patchset #1 (id:60001) has been deleted
Patchset #1 (id:80001) has been deleted
Patchset #1 (id:100001) has been deleted
lgtm
The CQ bit was checked by allada@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by allada@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org Link to the patchset: https://codereview.chromium.org/2443683002/#ps140001 (title: "Merge branch 'CLEANUP_DATAGRID_2' into NETWORK_TIMELINE_12_RESTRUCTURE_NETWORK_LOG_VIEW")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by allada@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Patchset #3 (id:160001) has been deleted
Patchset #3 (id:180001) has been deleted
The CQ bit was checked by allada@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org Link to the patchset: https://codereview.chromium.org/2443683002/#ps200001 (title: "changes")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by allada@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:200001)
Message was sent while issue was closed.
Description was changed from ========== [Devtools] Move NetworkTimelineColumn into NetworkLogViewColumns P1 This patch is restructuring NetworkLogView and NetworkLogViewColumns in preporation of moving all code relating to NetworkTimelineColumn into NetworkLogViewColumns. This is Part 1. R=dgozman BUG=653738 ========== to ========== [Devtools] Move NetworkTimelineColumn into NetworkLogViewColumns P1 This patch is restructuring NetworkLogView and NetworkLogViewColumns in preporation of moving all code relating to NetworkTimelineColumn into NetworkLogViewColumns. This is Part 1. R=dgozman BUG=653738 Committed: https://crrev.com/ab0c2f3cca120934b625f2ff7e8cc79ea4cf58cf Cr-Commit-Position: refs/heads/master@{#428051} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/ab0c2f3cca120934b625f2ff7e8cc79ea4cf58cf Cr-Commit-Position: refs/heads/master@{#428051} |