Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 2443683002: [Devtools] Move NetworkTimelineColumn into NetworkLogViewColumns P1 (Closed)

Created:
4 years, 2 months ago by allada
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Move NetworkTimelineColumn into NetworkLogViewColumns P1 This patch is restructuring NetworkLogView and NetworkLogViewColumns in preporation of moving all code relating to NetworkTimelineColumn into NetworkLogViewColumns. This is Part 1. R=dgozman BUG=653738 Committed: https://crrev.com/ab0c2f3cca120934b625f2ff7e8cc79ea4cf58cf Cr-Commit-Position: refs/heads/master@{#428051}

Patch Set 1 : changes #

Patch Set 2 : Merge branch 'CLEANUP_DATAGRID_2' into NETWORK_TIMELINE_12_RESTRUCTURE_NETWORK_LOG_VIEW #

Patch Set 3 : changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -55 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js View 1 5 chunks +23 lines, -39 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js View 1 2 8 chunks +53 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 33 (22 generated)
allada
PTL
4 years, 2 months ago (2016-10-21 20:41:13 UTC) #3
dgozman
lgtm
4 years, 1 month ago (2016-10-26 01:39:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443683002/140001
4 years, 1 month ago (2016-10-26 22:00:48 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/290374)
4 years, 1 month ago (2016-10-26 22:11:24 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443683002/140001
4 years, 1 month ago (2016-10-26 22:25:23 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/290410)
4 years, 1 month ago (2016-10-26 22:34:38 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443683002/200001
4 years, 1 month ago (2016-10-26 23:30:30 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/319990)
4 years, 1 month ago (2016-10-27 03:59:31 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443683002/200001
4 years, 1 month ago (2016-10-27 15:12:44 UTC) #30
commit-bot: I haz the power
Committed patchset #3 (id:200001)
4 years, 1 month ago (2016-10-27 16:36:30 UTC) #31
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 16:59:18 UTC) #33
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ab0c2f3cca120934b625f2ff7e8cc79ea4cf58cf
Cr-Commit-Position: refs/heads/master@{#428051}

Powered by Google App Engine
This is Rietveld 408576698