[Devtools] Fixed Scroll issues with network exp timeline

[Devtools] Fixed Scroll issues with network exp timeline

This patch fixes a few issues with scrolling and syncing between
DataGrid and the canvas timeline.

R=dgozman
BUG=653738
Committed: https://crrev.com/98fa178c8c8f0b088212389d70b2f887bec84ffd
Cr-Commit-Position: refs/heads/master@{#428217}

[allada, 2016-10-26 02:12:35]

Patchset #1 (id:1) has been deleted

[allada, 2016-10-26 02:13:58]

PTL

[dgozman, 2016-10-26 17:29:39]

I feel like we need to extract some ScrollSync component, as this is getting
complicated.

[allada, 2016-10-26 18:57:08]

Patchset #3 (id:60001) has been deleted

[allada, 2016-10-26 18:57:19]

Patchset #2 (id:40001) has been deleted

[allada, 2016-10-26 18:57:30]

Patchset #1 (id:20001) has been deleted

[allada, 2016-10-26 22:30:38]

Patchset #2 (id:100001) has been deleted

[allada, 2016-10-26 22:30:45]

PTaL

[allada, 2016-10-26 23:51:41]

Patchset #3 (id:140001) has been deleted

[allada, 2016-10-26 23:57:05]

Patchset #3 (id:160001) has been deleted

[allada, 2016-10-26 23:57:16]

Patchset #3 (id:180001) has been deleted

[dgozman, 2016-10-27 20:11:43]

lgtm with comments

https://codereview.chromium.org/2450133002/diff/90003/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
(right):

https://codereview.chromium.org/2450133002/diff/90003/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js:444:
this._dataGridScroller.addEventListener("mousewheel", event => {
Just this._onMouseWheel.bind(this), and consume inside.

https://codereview.chromium.org/2450133002/diff/90003/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js:483:
this._timelineColumn.setRightPadding(this._timelineScroller.offsetWidth -
this._timelineScrollerContent.offsetWidth);
This forces sync layout. We should cached the widths instead, or just avoid
this.

https://codereview.chromium.org/2450133002/diff/90003/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js:562:
this._timelineScroller.style.marginTop = rowHeight + "px";
Let's do this with css.

[allada, 2016-10-27 21:21:56]

done

https://codereview.chromium.org/2450133002/diff/90003/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
(right):

https://codereview.chromium.org/2450133002/diff/90003/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js:444:
this._dataGridScroller.addEventListener("mousewheel", event => {
On 2016/10/27 20:11:42, dgozman wrote:
> Just this._onMouseWheel.bind(this), and consume inside.

Done.

https://codereview.chromium.org/2450133002/diff/90003/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js:483:
this._timelineColumn.setRightPadding(this._timelineScroller.offsetWidth -
this._timelineScrollerContent.offsetWidth);
On 2016/10/27 20:11:42, dgozman wrote:
> This forces sync layout. We should cached the widths instead, or just avoid
> this.

Done.

https://codereview.chromium.org/2450133002/diff/90003/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js:562:
this._timelineScroller.style.marginTop = rowHeight + "px";
On 2016/10/27 20:11:42, dgozman wrote:
> Let's do this with css.

Done.

[allada, 2016-10-27 21:22:01]

The CQ bit was checked by allada@chromium.org

[allada, 2016-10-27 21:22:01]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2450133002/#ps210001
(title: "changes")

[commit-bot: I haz the power, 2016-10-27 21:23:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 22:41:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 22:41:25]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[allada, 2016-10-27 22:51:41]

The CQ bit was checked by allada@chromium.org

[commit-bot: I haz the power, 2016-10-27 22:52:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 23:39:06]

Committed patchset #4 (id:210001)

[commit-bot: I haz the power, 2016-10-27 23:42:23]

Description was changed from

==========
[Devtools] Fixed Scroll issues with network exp timeline

This patch fixes a few issues with scrolling and syncing between
DataGrid and the canvas timeline.

R=dgozman
BUG=653738
==========

to

==========
[Devtools] Fixed Scroll issues with network exp timeline

This patch fixes a few issues with scrolling and syncing between
DataGrid and the canvas timeline.

R=dgozman
BUG=653738

Committed: https://crrev.com/98fa178c8c8f0b088212389d70b2f887bec84ffd
Cr-Commit-Position: refs/heads/master@{#428217}
==========

[commit-bot: I haz the power, 2016-10-27 23:42:24]

Patchset 4 (id:??) landed as
https://crrev.com/98fa178c8c8f0b088212389d70b2f887bec84ffd
Cr-Commit-Position: refs/heads/master@{#428217}