Introduce EditCommand::setEndingSelection() taking SelectionInDOMTree

Introduce EditCommand::setEndingSelection() taking SelectionInDOMTree

This patch introduces |SelectionInDOMTree| version of |setEndingSelection()| in
|EditCommand| class as a preparation of getting rid of overloads and update
layout calls for improving code health.

Following patch will introduce SelectionInUndoStep which is intended for
restore selection after DOM tree mutation at undo/redo time.

BUG=648949, 646323
TEST=n/a; no behavior changes

Committed: https://crrev.com/d7c76ec65a164e8b0d1bcede4f6763026ce29042
Cr-Commit-Position: refs/heads/master@{#427585}

[yosin_UTC9, 2016-10-25 07:45:59]

Description was changed from

==========
2016-10-25T16:39:38

BUG=
==========

to

==========
2016-10-25T16:39:38

BUG=648949, 646323
==========

[yosin_UTC9, 2016-10-25 07:46:04]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 07:46:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-10-25 07:56:05]

Description was changed from

==========
2016-10-25T16:39:38

BUG=648949, 646323
==========

to

==========
Introduce EditCommand::setEndingSelection() taking SelectionInDOMTree

This patch introduces |SelectionInDOMTree| version of |setEndingSelection()| in
|EditCommand| class as a preparation of getting rid of overloads and update
layout calls.

BUG=648949, 646323
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-10-25 07:59:36]

Description was changed from

==========
Introduce EditCommand::setEndingSelection() taking SelectionInDOMTree

This patch introduces |SelectionInDOMTree| version of |setEndingSelection()| in
|EditCommand| class as a preparation of getting rid of overloads and update
layout calls.

BUG=648949, 646323
TEST=n/a; no behavior changes
==========

to

==========
Introduce EditCommand::setEndingSelection() taking SelectionInDOMTree

This patch introduces |SelectionInDOMTree| version of |setEndingSelection()| in
|EditCommand| class as a preparation of getting rid of overloads and update
layout calls for improving code health.

BUG=648949, 646323
TEST=n/a; no behavior changes
==========

[commit-bot: I haz the power, 2016-10-25 08:16:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 08:16:19]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[yosin_UTC9, 2016-10-25 09:27:16]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2016-10-25 09:27:17]

PTAL

[Xiaocheng, 2016-10-25 13:13:53]

SelectionInDOMTree verifies DOM tree version.

We need another class that is allowed to be stored though DOM mutations.

[yosin_UTC9, 2016-10-26 01:13:13]

Description was changed from

==========
Introduce EditCommand::setEndingSelection() taking SelectionInDOMTree

This patch introduces |SelectionInDOMTree| version of |setEndingSelection()| in
|EditCommand| class as a preparation of getting rid of overloads and update
layout calls for improving code health.

BUG=648949, 646323
TEST=n/a; no behavior changes
==========

to

==========
Introduce EditCommand::setEndingSelection() taking SelectionInDOMTree

This patch introduces |SelectionInDOMTree| version of |setEndingSelection()| in
|EditCommand| class as a preparation of getting rid of overloads and update
layout calls for improving code health.

Following patch will introduce SelectionInUndoStep which is intended for
restore selection after DOM tree mutation at undo/redo time.

BUG=648949, 646323
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-10-26 01:13:55]

On 2016/10/25 at 13:13:53, xiaochengh wrote:
> SelectionInDOMTree verifies DOM tree version.
> 
> We need another class that is allowed to be stored though DOM mutations.

Following patch will introduce SelectionInUndoStep which is intended for
restore selection after DOM tree mutation at undo/redo time.

I put above statement in description.

[Xiaocheng, 2016-10-26 02:01:10]

On 2016/10/26 at 01:13:55, yosin wrote:
> On 2016/10/25 at 13:13:53, xiaochengh wrote:
> > SelectionInDOMTree verifies DOM tree version.
> > 
> > We need another class that is allowed to be stored though DOM mutations.
> 
> Following patch will introduce SelectionInUndoStep which is intended for
> restore selection after DOM tree mutation at undo/redo time.
> 
> I put above statement in description.

Oh I see. So we only use SelectionInDOMTree in the |setEndingSelection|
interface but do not store SelectionInDOMTree?

[yosin_UTC9, 2016-10-26 02:12:03]

On 2016/10/26 at 02:01:10, xiaochengh wrote:
> On 2016/10/26 at 01:13:55, yosin wrote:
> > On 2016/10/25 at 13:13:53, xiaochengh wrote:
> > > SelectionInDOMTree verifies DOM tree version.
> > > 
> > > We need another class that is allowed to be stored though DOM mutations.
> > 
> > Following patch will introduce SelectionInUndoStep which is intended for
> > restore selection after DOM tree mutation at undo/redo time.
> > 
> > I put above statement in description.
> 
> Oh I see. So we only use SelectionInDOMTree in the |setEndingSelection|
interface but do not store SelectionInDOMTree?

Yes. As you mentioned, we won't hold |SelectionInDOMTree|.

[Xiaocheng, 2016-10-26 02:12:55]

lgtm

[yosin_UTC9, 2016-10-26 02:30:26]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-10-26 02:30:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 04:05:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-26 04:08:36]

Description was changed from

==========
Introduce EditCommand::setEndingSelection() taking SelectionInDOMTree

This patch introduces |SelectionInDOMTree| version of |setEndingSelection()| in
|EditCommand| class as a preparation of getting rid of overloads and update
layout calls for improving code health.

Following patch will introduce SelectionInUndoStep which is intended for
restore selection after DOM tree mutation at undo/redo time.

BUG=648949, 646323
TEST=n/a; no behavior changes
==========

to

==========
Introduce EditCommand::setEndingSelection() taking SelectionInDOMTree

This patch introduces |SelectionInDOMTree| version of |setEndingSelection()| in
|EditCommand| class as a preparation of getting rid of overloads and update
layout calls for improving code health.

Following patch will introduce SelectionInUndoStep which is intended for
restore selection after DOM tree mutation at undo/redo time.

BUG=648949, 646323
TEST=n/a; no behavior changes

Committed: https://crrev.com/d7c76ec65a164e8b0d1bcede4f6763026ce29042
Cr-Commit-Position: refs/heads/master@{#427585}
==========

[commit-bot: I haz the power, 2016-10-26 04:08:37]

Patchset 1 (id:??) landed as
https://crrev.com/d7c76ec65a164e8b0d1bcede4f6763026ce29042
Cr-Commit-Position: refs/heads/master@{#427585}