Introduce EditCommand::setEndingSelection() taking SelectionInDOMTree

third_party/WebKit/Source/core/editing/commands/EditCommand.cpp

 /*
  * Copyright (C) 2005, 2006, 2007 Apple, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 53 matching lines @@
     if (EditCommandComposition* composition = compositionIfPossible(command)) {
       DCHECK(command->isTopLevelCommand());
       composition->setStartingSelection(selection);
     }
     command->m_startingSelection = selection;
     if (!command->m_parent || command->m_parent->isFirstCommand(command))
       break;
   }
 }
 
+// TODO(yosin): We will make |SelectionInDOMTree| version of
+// |setEndingSelection()| as primary function instead of wrapper, once
+// |EditCommand| holds other than |VisibleSelection|.
+void EditCommand::setEndingSelection(const SelectionInDOMTree& selection) {
+  // TODO(editing-dev): The use of
+  // updateStyleAndLayoutIgnorePendingStylesheets
+  // needs to be audited.  See http://crbug.com/590369 for more details.
+  document().updateStyleAndLayoutIgnorePendingStylesheets();
+  setEndingSelection(createVisibleSelection(selection));
+}
+
+// TODO(yosin): We will make |SelectionInDOMTree| version of
+// |setEndingSelection()| as primary function instead of wrapper.
 void EditCommand::setEndingSelection(const VisibleSelection& selection) {
   for (EditCommand* command = this; command; command = command->m_parent) {
     if (EditCommandComposition* composition = compositionIfPossible(command)) {
       DCHECK(command->isTopLevelCommand());
       composition->setEndingSelection(selection);
     }
     command->m_endingSelection = selection;
   }
 }
 
+// TODO(yosin): We will make |SelectionInDOMTree| version of
+// |setEndingSelection()| as primary function instead of wrapper.
 void EditCommand::setEndingSelection(const VisiblePosition& position) {
   if (position.isNull()) {
-    setEndingSelection(VisibleSelection());
+    setEndingSelection(SelectionInDOMTree());
     return;
   }
-  setEndingSelection(
-      createVisibleSelection(SelectionInDOMTree::Builder()
-                                 .collapse(position.toPositionWithAffinity())
-                                 .build()));
+  setEndingSelection(SelectionInDOMTree::Builder()
+                         .collapse(position.toPositionWithAffinity())
+                         .build());
 }
 
 bool EditCommand::isRenderedCharacter(const Position& position) {
   if (position.isNull())
     return false;
   DCHECK(position.isOffsetInAnchor()) << position;
   if (!position.anchorNode()->isTextNode())
     return false;
 
   LayoutObject* layoutObject = position.anchorNode()->layoutObject();
@@ skipping 21 matching lines @@
 }
 
 DEFINE_TRACE(EditCommand) {
   visitor->trace(m_document);
   visitor->trace(m_startingSelection);
   visitor->trace(m_endingSelection);
   visitor->trace(m_parent);
 }
 
 }  // namespace blink