Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Side by Side Diff: third_party/WebKit/Source/core/editing/commands/EditCommand.h

Issue 2450603003: Introduce EditCommand::setEndingSelection() taking SelectionInDOMTree (Closed)
Patch Set: 2016-10-25T16:39:38 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/commands/EditCommand.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2005, 2006, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2005, 2006, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 virtual String textDataForInputEvent() const; 61 virtual String textDataForInputEvent() const;
62 62
63 DECLARE_VIRTUAL_TRACE(); 63 DECLARE_VIRTUAL_TRACE();
64 64
65 protected: 65 protected:
66 explicit EditCommand(Document&); 66 explicit EditCommand(Document&);
67 67
68 Document& document() const { return *m_document.get(); } 68 Document& document() const { return *m_document.get(); }
69 CompositeEditCommand* parent() const { return m_parent; } 69 CompositeEditCommand* parent() const { return m_parent; }
70 void setStartingSelection(const VisibleSelection&); 70 void setStartingSelection(const VisibleSelection&);
71 void setEndingSelection(const SelectionInDOMTree&);
72 // TODO(yosin): We should get rid of overloads of |setEndingSelection()|
73 // except for taking |SelectionInDOMTree|.
71 void setEndingSelection(const VisibleSelection&); 74 void setEndingSelection(const VisibleSelection&);
72 void setEndingSelection(const VisiblePosition&); 75 void setEndingSelection(const VisiblePosition&);
73 76
74 // TODO(yosin) |isRenderedCharacter()| should be removed, and we should use 77 // TODO(yosin) |isRenderedCharacter()| should be removed, and we should use
75 // |VisiblePosition::characterAfter()| and 78 // |VisiblePosition::characterAfter()| and
76 // |VisiblePosition::characterBefore()|. 79 // |VisiblePosition::characterBefore()|.
77 static bool isRenderedCharacter(const Position&); 80 static bool isRenderedCharacter(const Position&);
78 81
79 private: 82 private:
80 Member<Document> m_document; 83 Member<Document> m_document;
(...skipping 21 matching lines...) Expand all
102 105
103 DEFINE_TYPE_CASTS(SimpleEditCommand, 106 DEFINE_TYPE_CASTS(SimpleEditCommand,
104 EditCommand, 107 EditCommand,
105 command, 108 command,
106 command->isSimpleEditCommand(), 109 command->isSimpleEditCommand(),
107 command.isSimpleEditCommand()); 110 command.isSimpleEditCommand());
108 111
109 } // namespace blink 112 } // namespace blink
110 113
111 #endif // EditCommand_h 114 #endif // EditCommand_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/commands/EditCommand.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698