Add pending line item support for web payments.

Add pending line item support for web payments.

The API allows merchants to indicate when a line item is not yet final.
 - https://github.com/w3c/browser-payment-api/pull/270
 - https://w3c.github.io/browser-payment-api/#paymentitem-dictionary

BUG=648050
Committed: https://crrev.com/4044a8eac985b745ef29d3fce702df67a5d39c21
Cr-Commit-Position: refs/heads/master@{#427723}

[please use gerrit instead, 2016-10-25 14:37:34]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 14:37:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 15:55:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 15:55:40]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2016-10-25 17:50:55]

rouslan@chromium.org changed reviewers:
+ dfalcantara@chromium.org, mathp@chromium.org

[please use gerrit instead, 2016-10-25 17:50:55]

dfalcantara, ptal chrome/android/.

mathp, ptal third_party/WebKit/.

[please use gerrit instead, 2016-10-25 17:52:49]

rouslan@chromium.org changed reviewers:
+ tsepez@chromium.org

[please use gerrit instead, 2016-10-25 17:52:50]

tsepez, ptal components/payments/payment_request.mojom.

[Tom Sepez, 2016-10-25 20:11:16]

lgtm

[Mathieu, 2016-10-26 02:04:59]

WebKit lgtm

https://codereview.chromium.org/2449943002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
(right):

https://codereview.chromium.org/2449943002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:568:
LineItem uiTotal = new LineItem(
nit: can you add a comment saying that the total is never pending or something
like this?

and/or

formatter.format(details.total.amount.value), /* isPending = */ false);

so that this detail is not lost to the reader

[please use gerrit instead, 2016-10-26 13:48:16]

https://codereview.chromium.org/2449943002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
(right):

https://codereview.chromium.org/2449943002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:568:
LineItem uiTotal = new LineItem(
On 2016/10/26 02:04:59, Mathieu Perreault wrote:
> nit: can you add a comment saying that the total is never pending or something
> like this?
> 
> and/or
> 
> formatter.format(details.total.amount.value), /* isPending = */ false);
> 
> so that this detail is not lost to the reader

Done.

[please use gerrit instead, 2016-10-26 13:48:48]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 13:49:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 16:19:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 16:19:26]

Dry run: This issue passed the CQ dry run.

[gone, 2016-10-26 16:58:47]

lgtm

[please use gerrit instead, 2016-10-26 16:59:35]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2016-10-26 16:59:35]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org,
tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2449943002/#ps20001
(title: "Comments")

[commit-bot: I haz the power, 2016-10-26 17:00:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 17:05:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-26 17:50:36]

Description was changed from

==========
Add pending line item support for web payments.

The API allows merchants to indicate when a line item is not yet final.
 - https://github.com/w3c/browser-payment-api/pull/270
 - https://w3c.github.io/browser-payment-api/#paymentitem-dictionary

BUG=648050
==========

to

==========
Add pending line item support for web payments.

The API allows merchants to indicate when a line item is not yet final.
 - https://github.com/w3c/browser-payment-api/pull/270
 - https://w3c.github.io/browser-payment-api/#paymentitem-dictionary

BUG=648050

Committed: https://crrev.com/4044a8eac985b745ef29d3fce702df67a5d39c21
Cr-Commit-Position: refs/heads/master@{#427723}
==========

[commit-bot: I haz the power, 2016-10-26 17:50:39]

Patchset 2 (id:??) landed as
https://crrev.com/4044a8eac985b745ef29d3fce702df67a5d39c21
Cr-Commit-Position: refs/heads/master@{#427723}