Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2742)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

Issue 2449943002: Add pending line item support for web payments. (Closed)
Patch Set: Comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
index 26bbd0f448e358b1cf04bbefa9ffad28e0f367e9..e2b68f807709cd24f732825d715e689d47123251 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
@@ -566,9 +566,10 @@ public class PaymentRequestImpl implements PaymentRequest, PaymentRequestUI.Clie
return false;
}
+ // Total is never pending.
LineItem uiTotal = new LineItem(
details.total.label, formatter.getFormattedCurrencyCode(),
- formatter.format(details.total.amount.value));
+ formatter.format(details.total.amount.value), /* isPending */ false);
List<LineItem> uiLineItems = getValidatedLineItems(details.displayItems, totalCurrency,
formatter);
@@ -633,7 +634,8 @@ public class PaymentRequestImpl implements PaymentRequest, PaymentRequestUI.Clie
// Value should be in correct format.
if (!formatter.isValidAmountValue(item.amount.value)) return null;
- result.add(new LineItem(item.label, "", formatter.format(item.amount.value)));
+ result.add(new LineItem(
+ item.label, "", formatter.format(item.amount.value), item.pending));
}
return result;

Powered by Google App Engine
This is Rietveld 408576698