Add pending line item support for web payments.

chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.payments;
 
 import android.app.Activity;
 import android.graphics.Bitmap;
 import android.os.Handler;
 import android.text.TextUtils;
@@ skipping 547 matching lines @@
         }
 
         if (!formatter.isValidAmountValue(details.total.amount.value)
                 || details.total.amount.value.startsWith("-")) {
             disconnectFromClientWithDebugMessage("Invalid total amount value");
             recordAbortReasonHistogram(
                     PaymentRequestMetrics.ABORT_REASON_INVALID_DATA_FROM_RENDERER);
             return false;
         }
 
         LineItem uiTotal = new LineItem(

[Mathieu, 2016/10/26 02:04:59]

nit: can you add a comment saying that the total is never pending or something
like this?

and/or

formatter.format(details.total.amount.value), /* isPending = */ false);

so that this detail is not lost to the reader

[please use gerrit instead, 2016/10/26 13:48:16]

Done.

                 details.total.label, formatter.getFormattedCurrencyCode(),
-                formatter.format(details.total.amount.value));
+                formatter.format(details.total.amount.value), false);
 
         List<LineItem> uiLineItems = getValidatedLineItems(details.displayItems, totalCurrency,
                 formatter);
         if (uiLineItems == null) {
             disconnectFromClientWithDebugMessage("Invalid line items");
             recordAbortReasonHistogram(
                     PaymentRequestMetrics.ABORT_REASON_INVALID_DATA_FROM_RENDERER);
             return false;
         }
 
@@ skipping 44 matching lines @@
             PaymentItem item = items[i];
 
             if (!hasAllPaymentItemFields(item)) return null;
 
             // All currencies must match.
             if (!item.amount.currency.equals(totalCurrency)) return null;
 
             // Value should be in correct format.
             if (!formatter.isValidAmountValue(item.amount.value)) return null;
 
-            result.add(new LineItem(item.label, "", formatter.format(item.amount.value)));
+            result.add(new LineItem(
+                    item.label, "", formatter.format(item.amount.value), item.pending));
         }
 
         return result;
     }
 
     /**
      * Validates a list of shipping options and returns their parsed representation or null if
      * invalid.
      *
      * @param options The raw shipping options to parse and validate.
@@ skipping 574 matching lines @@
                 "PaymentRequest.CheckoutFunnel.Aborted", abortReason,
                 PaymentRequestMetrics.ABORT_REASON_MAX);
 
         if (abortReason == PaymentRequestMetrics.ABORT_REASON_ABORTED_BY_USER) {
             mJourneyLogger.recordJourneyStatsHistograms("UserAborted");
         } else {
             mJourneyLogger.recordJourneyStatsHistograms("OtherAborted");
         }
     }
 }