Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2449923004: Fix blink side WebGL2 sync object related behaviors. (Closed)

Created:
4 years, 1 month ago by Zhenyao Mo
Modified:
4 years, 1 month ago
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix blink side WebGL2 sync object related behaviors. BUG=295792 TEST=webgl2_conformance R=kbr@chromium.org,kainino@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/427296589b99b1034e3cca05ff2d03343b3bf61d Cr-Commit-Position: refs/heads/master@{#427615}

Patch Set 1 #

Patch Set 2 : update expectations #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -16 lines) Patch
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 1 2 4 chunks +16 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl View 1 2 chunks +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 22 (13 generated)
Zhenyao Mo
Ken, Kai: PTAL
4 years, 1 month ago (2016-10-25 21:46:46 UTC) #3
Ken Russell (switch to Gerrit)
Thanks for cleaning this up. LGTM
4 years, 1 month ago (2016-10-25 21:58:34 UTC) #5
Kai Ninomiya
lgtm
4 years, 1 month ago (2016-10-25 22:40:02 UTC) #6
Ken Russell (switch to Gerrit)
lgtm again
4 years, 1 month ago (2016-10-26 01:46:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449923004/40001
4 years, 1 month ago (2016-10-26 01:57:34 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/293614) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 1 month ago (2016-10-26 02:13:37 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449923004/40001
4 years, 1 month ago (2016-10-26 05:02:02 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-26 06:43:43 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 06:45:06 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/427296589b99b1034e3cca05ff2d03343b3bf61d
Cr-Commit-Position: refs/heads/master@{#427615}

Powered by Google App Engine
This is Rietveld 408576698