Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 2449213006: Factor out ShouldIgnoreNavigation and add tests for the function (Closed)

Created:
4 years, 1 month ago by Yusuke Sato
Modified:
4 years, 1 month ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Factor out ShouldIgnoreNavigation and add tests for the function BUG=None TEST=try Committed: https://crrev.com/41621e339b93300359f34c696a21a3671ec4dae8 Cr-Commit-Position: refs/heads/master@{#428100}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -10 lines) Patch
M chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc View 3 chunks +19 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog_unittest.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Yusuke Sato
PTAL
4 years, 1 month ago (2016-10-27 01:58:13 UTC) #6
Luis Héctor Chávez
lgtm
4 years, 1 month ago (2016-10-27 16:10:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449213006/1
4 years, 1 month ago (2016-10-27 18:53:16 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 18:59:10 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 19:03:48 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/41621e339b93300359f34c696a21a3671ec4dae8
Cr-Commit-Position: refs/heads/master@{#428100}

Powered by Google App Engine
This is Rietveld 408576698