Factor out ShouldIgnoreNavigation and add tests for the function

chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.h"
 
 #include <memory>
 #include <utility>
 #include <vector>
 
@@ skipping 321 matching lines @@
   // Otherwise, retrieve icons of the activities.
   std::vector<ActivityIconLoader::ActivityName> activities;
   for (const auto& handler : handlers) {
     activities.emplace_back(handler->package_name, handler->activity_name);
   }
   icon_loader->GetActivityIcons(
       activities, base::Bind(OnAppIconsReceived, render_process_host_id,
                              routing_id, url, base::Passed(&handlers)));
 }
 
+// Returns true if ARC should ignore the navigation with the |page_transition|.
+bool ShouldIgnoreNavigation(ui::PageTransition page_transition) {
+  // Handle client-side redirections. Forwarding such navigations to ARC is
+  // better than just showing the "can't open" dialog.
+  // TODO(djacobo): Check if doing this in arc::ShouldIgnoreNavigation is safe,
+  // and move it to the function if it is. (b/32442730#comment3)
+  page_transition = ui::PageTransitionFromInt(
+      page_transition & ~ui::PAGE_TRANSITION_CLIENT_REDIRECT);
+
+  // Try to forward <form> submissions to ARC when possible.
+  constexpr bool kAllowFormSubmit = true;
+  return arc::ShouldIgnoreNavigation(page_transition, kAllowFormSubmit);
+}
+
 }  // namespace
 
 bool RunArcExternalProtocolDialog(const GURL& url,
                                   int render_process_host_id,
                                   int routing_id,
                                   ui::PageTransition page_transition,
                                   bool has_user_gesture) {
   // This function is for external protocols that Chrome cannot handle.
   DCHECK(!url.SchemeIsHTTPOrHTTPS()) << url;
 
-  // Handle client-side redirections. Forwarding such navigations to ARC is
-  // better than just showing the "can't open" dialog.
-  // TODO(djacobo): Check if doing this in arc::ShouldIgnoreNavigation is safe,
-  // and move it to the function if it is. (b/32442730#comment3)
-  page_transition = ui::PageTransitionFromInt(
-      page_transition & ~ui::PAGE_TRANSITION_CLIENT_REDIRECT);
-
-  // Try to forward <form> submissions to ARC when possible.
-  constexpr bool kAllowFormSubmit = true;
-  if (ShouldIgnoreNavigation(page_transition, kAllowFormSubmit))
+  if (ShouldIgnoreNavigation(page_transition))
     return false;
 
   auto* instance = ArcIntentHelperBridge::GetIntentHelperInstance(
       "RequestUrlHandlerList", kMinVersionForRequestUrlHandlerList);
   if (!instance)
     return false;  // ARC is either not supported or not yet ready.
 
   WebContents* web_contents =
       tab_util::GetWebContentsByID(render_process_host_id, routing_id);
   if (!web_contents || !web_contents->GetBrowserContext() ||
       web_contents->GetBrowserContext()->IsOffTheRecord()) {
     return false;
   }
 
   // Show ARC version of the dialog, which is IntentPickerBubbleView. To show
   // the bubble view, we need to ask ARC for a handler list first.
   instance->RequestUrlHandlerList(
       url.spec(),
       base::Bind(OnUrlHandlerList, render_process_host_id, routing_id, url));
   return true;
 }
 
+bool ShouldIgnoreNavigationForTesting(ui::PageTransition page_transition) {
+  return ShouldIgnoreNavigation(page_transition);
+}
+
 GetActionResult GetActionForTesting(
     const GURL& original_url,
     const mojo::Array<mojom::IntentHandlerInfoPtr>& handlers,
     size_t selected_app_index,
     std::pair<GURL, std::string>* out_url_and_package) {
   return GetAction(original_url, handlers, selected_app_index,
                    out_url_and_package);
 }
 
 }  // namespace arc