chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.h - Issue 2449213006: Factor out ShouldIgnoreNavigation and add tests for the function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.h

Issue 2449213006: Factor out ShouldIgnoreNavigation and add tests for the function (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.h

diff --git a/chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.h b/chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.h

index 1983473a14d2286010fc08387ff76441d9050ac5..f2de5b8cc6e2776f8f19a6e281ab5f047571f0fc 100644

--- a/chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.h

+++ b/chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.h

@@ -31,6 +31,8 @@ bool RunArcExternalProtocolDialog(const GURL& url,

ui::PageTransition page_transition,

bool has_user_gesture);

+bool ShouldIgnoreNavigationForTesting(ui::PageTransition page_transition);

GetActionResult GetActionForTesting(

const GURL& original_url,

const mojo::Array<mojom::IntentHandlerInfoPtr>& handlers,

« no previous file with comments | « no previous file | chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc » ('j') | no next file with comments »