Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2449173002: DevTools: fix jsdoc validator to recognize `this' usage within arrow functions (Closed)

Created:
4 years, 1 month ago by caseq
Modified:
4 years, 1 month ago
Reviewers:
dgozman, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix jsdoc validator to recognize `this' usage within arrow functions Arrow functions implicitly bind to this, but the validator was ignoring the fact and warned on unused this in the outer function when its nested arrow function was actually binding to this. Committed: https://crrev.com/1b47d6a1606ab62ce03a09a4f7746d16900edd87 Cr-Commit-Position: refs/heads/master@{#427435}

Patch Set 1 #

Total comments: 1

Patch Set 2 : review comments + moar tests #

Messages

Total messages: 9 (4 generated)
caseq
4 years, 1 month ago (2016-10-25 18:00:37 UTC) #2
dgozman
lgtm https://codereview.chromium.org/2449173002/diff/1/third_party/WebKit/Source/devtools/scripts/jsdoc-validator/tests/this.js File third_party/WebKit/Source/devtools/scripts/jsdoc-validator/tests/this.js (right): https://codereview.chromium.org/2449173002/diff/1/third_party/WebKit/Source/devtools/scripts/jsdoc-validator/tests/this.js#newcode302 third_party/WebKit/Source/devtools/scripts/jsdoc-validator/tests/this.js:302: * @this {!C} @this annotations don't need "!"
4 years, 1 month ago (2016-10-25 18:08:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449173002/20001
4 years, 1 month ago (2016-10-25 18:13:26 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-25 19:08:10 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 19:35:49 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1b47d6a1606ab62ce03a09a4f7746d16900edd87
Cr-Commit-Position: refs/heads/master@{#427435}

Powered by Google App Engine
This is Rietveld 408576698